[feat] Redis를 이용한 Rate Limiter 적용 (#34) #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthisag246
requested review from
win-luck,
pjw-redt,
alsrudrl1220 and
RumosZin
3 tasks
tthisag246
commented
Aug 24, 2024
| private final RedisClient redisClient; | ||
|
|
||
| @Bean | ||
| public LettuceBasedProxyManager<String> proxyManager() { |
tthisag246
commented
Aug 24, 2024
| @@ -33,4 +40,9 @@ public RedisTemplate<String, Long> redisTemplate(RedisConnectionFactory connecti | |||
| public StringRedisTemplate stringRedisTemplate(RedisConnectionFactory connectionFactory) { | |||
| return new StringRedisTemplate(connectionFactory); | |||
| } | |||
|
|
|||
| @Bean | |||
| public RedisClient redisClient() { | |||
There was a problem hiding this comment.
LettuceBasedProxyManager 객체 생성에 필요
tthisag246
commented
Aug 24, 2024
|
|
||
| @Override | ||
| public void addArgumentResolvers(List<HandlerMethodArgumentResolver> resolvers) { | ||
| resolvers.add(puangUserArgumentResolver); | ||
| } | ||
|
|
||
| @Override | ||
| public void addInterceptors(InterceptorRegistry registry) { |
tthisag246
commented
Aug 24, 2024
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum RateLimitPolicy { |
tthisag246
commented
Aug 24, 2024
| private final String BLOCKED_PREFIX = "rate-limiter-blocked:"; | ||
|
|
||
| @Override | ||
| public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) throws Exception { |
tthisag246
commented
Aug 24, 2024
| String servletPath = request.getServletPath(); | ||
| String key = kakaoId + servletPath; | ||
|
|
||
| if (isBlocked(key)) { |
tthisag246
commented
Aug 24, 2024
| } | ||
|
|
||
| // key에 해당하는 bucket 로드. 없으면 생성 | ||
| Bucket bucket = proxyManager.getProxy(LIMITER_PREFIX + key, () -> getRateLimitPolicy(servletPath)); |
tthisag246
commented
Aug 24, 2024
| // key에 해당하는 bucket 로드. 없으면 생성 | ||
| Bucket bucket = proxyManager.getProxy(LIMITER_PREFIX + key, () -> getRateLimitPolicy(servletPath)); | ||
|
|
||
| if (!bucket.tryConsume(1)) { |
There was a problem hiding this comment.
토큰 소비 시도
토큰 소진 시 사용자 차단
win-luck
approved these changes
Aug 24, 2024
Comment on lines
+43
to
+53
| public abstract Bandwidth getLimit(); | ||
|
|
||
| private final String planName; | ||
|
|
||
| public static Bandwidth resolvePlan(final String targetPlan) { | ||
| return Arrays.stream(RateLimitPolicy.values()) | ||
| .filter(policy -> policy.getPlanName().equals(targetPlan)) | ||
| .map(RateLimitPolicy::getLimit) | ||
| .findFirst() | ||
| .orElseThrow(() -> new RateLimiterException(ResponseCode.RATE_LIMITER_POLICY_ERROR)); | ||
| } |
There was a problem hiding this comment.
변수는 맨 위로 옮기는 게 좋을 것 같아요~!
Comment on lines
+57
to
+73
| private BucketConfiguration getRateLimitPolicy(String contextPath) { | ||
| switch (contextPath) { | ||
| case "/api/photo-request": | ||
| return bucketConfiguration("heavy"); | ||
|
|
||
| default: | ||
| return bucketConfiguration("general"); | ||
| } | ||
| } | ||
|
|
||
| private void blockClient(String key) { | ||
| redisTemplate.opsForValue().set(BLOCKED_PREFIX + key, 0L, Duration.ofMinutes(5)); | ||
| } | ||
|
|
||
| private boolean isBlocked(String key) { | ||
| return Boolean.TRUE.equals(redisTemplate.hasKey(BLOCKED_PREFIX + key)); | ||
| } |
There was a problem hiding this comment.
이렇게 따로 코드에 메서드명을 설정해서 구체적인 의미를 표현하는 것 좋습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
참고 이미지 및 자료
💬 리뷰 요구사항