Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters Added for speaker #108

Merged
merged 10 commits into from
Oct 7, 2019
Merged

Conversation

pAditya198
Copy link
Contributor

When None of the Filters are selected :

Screenshot (150)

When Machine Learning is Selected as Filter :

Screenshot (151)

When Mobile is Selected as Filter :

Screenshot (152)

@pAditya198
Copy link
Contributor Author

Schedule Component Also Initialized
linked with speakers firebase

With dummy_data :

Screenshot (153)

With data :

Screenshot (154)

@pAditya198
Copy link
Contributor Author

pAditya198 commented Oct 1, 2019

@samagragupta @aashutoshrathi Please review

Also Some UI fixes needed.

related to issue #81

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are here.
@rossoskull @samagragupta Tell more about styling

Copy link
Contributor

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a border around the filter buttons.

@pAditya198
Copy link
Contributor Author

Instead of button I've used Checkbox they look more classic and also less variables are used.
Some screenshot are provided below as an example of multiple checks.

Screenshot (156)

Screenshot (157)

Screenshot (158)

Screenshot (159)

@pAditya198
Copy link
Contributor Author

Review changes are also fixed @aashutoshrathi

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a schedule entry in the navbar which will only be shown when the show is true in Firebase.
Also, the elements are not centered properly in Schedule element.

@pAditya198
Copy link
Contributor Author

@aashutoshrathi should I create a new model for schedule because here I'm using the existing data from speakers

Copy link
Contributor

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the colour of the checkbox: #00aaf5
Shift the content of the Schedule page at the centre.

@AmanRaj1608
Copy link
Contributor

@samagragupta @aashutoshrathi
Is this schedule UI okay pAditya198#7

@aashutoshrathi
Copy link
Member

@samagragupta Check once more, we will merge it then

@pAditya198
Copy link
Contributor Author

@samagragupta @aashutoshrathi
Is this schedule UI okay pAditya198#7

@samagragupta @aashutoshrathi suggest UI changes or should I just merge this commit.

@parth181195
Copy link
Collaborator

can nu finish the change @aashutoshrathi has requested so i can merge this in master

@parth181195 parth181195 merged commit fb368c7 into GDG-GANDHINAGAR:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants