-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters Added for speaker #108
Conversation
@samagragupta @aashutoshrathi Please review Also Some UI fixes needed. related to issue #81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes are here.
@rossoskull @samagragupta Tell more about styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a border around the filter buttons.
Review changes are also fixed @aashutoshrathi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a schedule entry in the navbar which will only be shown when the show is true in Firebase.
Also, the elements are not centered properly in Schedule element.
@aashutoshrathi should I create a new model for schedule because here I'm using the existing data from speakers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the colour of the checkbox: #00aaf5
Shift the content of the Schedule page at the centre.
@samagragupta @aashutoshrathi |
@samagragupta Check once more, we will merge it then |
@samagragupta @aashutoshrathi suggest UI changes or should I just merge this commit. |
can nu finish the change @aashutoshrathi has requested so i can merge this in master |
When None of the Filters are selected :
When Machine Learning is Selected as Filter :
When Mobile is Selected as Filter :