Add kernel user dtb extraction #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rageagainsthepc
force-pushed
the
add-kernel-userDTB-extraction
branch
3 times, most recently
from
9a78e33
to
17be369
Compare
rageagainsthepc
force-pushed
the
add-kernel-userDTB-extraction
branch
9 times, most recently
from
4474c47
to
45c5d35
Compare
thomasdangl
requested changes
Sep 5, 2023
| // Check if kernel is recent enough to have PTI support (backports for LTS releases are currently ignored) | ||
| if (auto [major, minor, _patch] = extractKernelVersion(); major > 4 || (major == 4 && minor >= 15)) | ||
| { | ||
| // Check if kernel page table isolation is enabled |
There was a problem hiding this comment.
This will fail poorly on ARM
There was a problem hiding this comment.
The project is not yet ARM aware, but I am open to alternative suggestions.
There was a problem hiding this comment.
Merging that functionality could be a good idea
There was a problem hiding this comment.
IIRC That PR still had open review comments. If you finish that PR and rebase it onto the newest version, I'd be happy to merge it.
rageagainsthepc
force-pushed
the
add-kernel-userDTB-extraction
branch
3 times, most recently
from
91ab0e8
to
8bf67c5
Compare
thomasdangl
requested changes
Sep 7, 2023
rageagainsthepc
force-pushed
the
add-kernel-userDTB-extraction
branch
from
8bf67c5
to
541e11e
Compare
|
[InMemoryScanner Plugin] Kudos, SonarCloud Quality Gate passed!
|
|
[ApiTracing Plugin] Kudos, SonarCloud Quality Gate passed! |
|
[VMICore] Kudos, SonarCloud Quality Gate passed! |
thomasdangl
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.