WIP add test for unknown type exceptions

GDATASoftwareAG · Sep 18, 2023 · 591479d · 591479d
1 parent 0e57d03
commit 591479d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 10 deletions.
diff --git a/plugins/apitracing/src/lib/os/Extractor.cpp b/plugins/apitracing/src/lib/os/Extractor.cpp
@@ -129,15 +129,15 @@ namespace ApiTracing
         ExtractedParameterInformation result{};
         result.name = parameterInfo.name;
         BasicTypes parameterType;
-        try
-        {
-            parameterType = basicTypeStringToEnum.at(parameterInfo.basicType);
-        }
-        catch (...)
-        {
-            std::throw_with_nested(
-                std::invalid_argument(fmt::format("Parameter not defined: {}", parameterInfo.basicType)));
-        }
+        // try
+        //{
+        parameterType = basicTypeStringToEnum.at(parameterInfo.basicType);
+        //}
+        // catch (...)
+        //{
+        //        std::throw_with_nested(
+        //            std::invalid_argument(fmt::format("Parameter not defined: {}", parameterInfo.basicType)));
+        //}
         switch (parameterType)
         {
             using enum BasicTypes;

diff --git a/plugins/apitracing/test/Extractor_Unittest.cpp b/plugins/apitracing/test/Extractor_Unittest.cpp
@@ -66,7 +66,6 @@ namespace ApiTracing
         // clang-format off
         // @formatter:off
         const auto testParams32 = std::vector<TestParameterInformation>{
-
             {.parameterInformation{.name = "param1", .size = TestConstantDefinitions::fourBytes, .backingParameters{}},
              .expectedValue = param1Value},
             {.parameterInformation{.name = "param2", .size = TestConstantDefinitions::fourBytes, .backingParameters{}},
@@ -78,6 +77,12 @@ namespace ApiTracing
             {.parameterInformation{.name = "param5", .size = TestConstantDefinitions::fourBytes, .backingParameters{}},
              .expectedValue = param5Value},
         };
+
+        const auto testParamUnknownType = std::vector<TestParameterInformation>{
+            {.parameterInformation{.basicType = "__unknown int96", .name = "UnknownType", .size = TestConstantDefinitions::fourBytes, .backingParameters{}},
+                .expectedValue = param1Value},
+
+};
         // @formatter:on
         // clang-format on
 
@@ -305,4 +310,17 @@ namespace ApiTracing
         ASSERT_EQ(actualParameters.size(), expectedExtractedParameters.size());
         EXPECT_THAT(expectedExtractedParameters, ContainerEq(actualParameters));
     }
+
+    TEST_F(ExtractorFixture, extractParameters_64Bit1ParameterFunctionUnknownType_ExtractionFails)
+    {
+        auto extractor =
+            std::make_shared<Extractor>(introspectionAPI, pluginInterface.get(), ConstantDefinitions::x64AddressWidth);
+        SetupParameterInformation(std::vector<TestParameterInformation>(testParamUnknownType));
+
+        auto shallowParameters = extractor->getShallowExtractedParams(*interruptEvent, paramInformation);
+
+        EXPECT_THAT([]() { extractor->getDeepExtractParameters(shallowParameters, paramInformation, testDtb); },
+                    Throws < std::out:of
+                    : range_error > ());
+    }
 }