Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add recipient fee by basis points #183

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ogarciarevett
Copy link
Collaborator

Issue: Fix latest audit session issues in the RewardsNative contract + Add the new split payment functionallity to the PaymentRouterNative

🐵 Description

  • Removed multisig wallet functionality in favor of direct fee recipient management
  • Simplified fee recipient logic by removing strict 100% requirement during individual operations
  • Added validation to ensure 100% fee distribution only during payment execution
  • Updated emergency withdrawal to send funds to admin caller instead of multisig
  • Added comprehensive test suite for fee recipient management

🙊 Checklist:

  • I have added tests proving my fix is effective or that my feature works
  • Contract deployed to testnet(only for new contracts)

@ogarciarevett ogarciarevett self-assigned this Jan 8, 2025
Copy link

octane-security-app bot commented Jan 8, 2025

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • PaymentRouterNative.sol: The contract now includes customizable fee recipients, allowing distributed payments, replaces the multisig wallet handling mechanism, and introduces relevant events and errors.
  • Rewards.sol: Changed loop variable type from uint to uint256 for consistency and clarity.
  • RewardsNative.sol: The modifications remove whitelist signature verification and related functions, streamline initialization checks, and maintain reward management.

🔗 Commit Hash: 7797a99

Copy link

openzeppelin-code bot commented Jan 8, 2025

Feat: Add recipient fee by basis points

Generated at commit: 7797a996e44f2af7467bb510e74a3df31a48634a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
11
41
58
Dependencies Critical
High
Medium
Low
Note
Total
1
0
0
0
0
1

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@vasinl124 vasinl124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

octane-security-app bot commented Jan 8, 2025

Overview

Vulnerabilities found: 8                                                                                
Severity breakdown: 5 Medium, 3 Low

Detailed findings

contracts/libraries/Address.sol

contracts/payments/PaymentRouterNative.sol

contracts/soulbounds/RewardsNative.sol


🔗 Commit Hash: 7797a99
🛡️ Octane Dashboard: All vulnerabilities

@ogarciarevett ogarciarevett merged commit 4ee41b6 into main Jan 9, 2025
2 checks passed
@ogarciarevett ogarciarevett deleted the feat/SUM-1251-split-payments branch January 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants