Feat: Add OpenZeppelin ERC20 tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karacurt
force-pushed
the
feat/erc20-tests
branch
from
0565ae8 to
a1deb25
Compare
karacurt
changed the title
karacurt
changed the title
kellan-simiotics
approved these changes
Jun 6, 2024
| @@ -5,6 +5,8 @@ | |||
| "packages": { | |||
There was a problem hiding this comment.
We probably don't need to check in the lock file.
| require(allowance[from][msg.sender] >= value); | ||
| allowance[from][msg.sender] -= value; | ||
| } | ||
| if (msg.sender != from && allowance[from][msg.sender] != type(uint256).max) { |
There was a problem hiding this comment.
Seems as though the Openzeppelin contract allows setting an allowance on yourself. Don't have a strong preference on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.