added ImmutablePoolCreator contract #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew Contracts
Updated ContractsNo contracts were updated in this PR. 🔗 Commit Hash: 98cafec |
|
Thanks @mikechaban ! This is great. But it is lacking tests - could you please add tests, as well? |
mrk-hub
reviewed
Jan 27, 2025
| @@ -0,0 +1,45 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.0; | |||
|
|
|||
There was a problem hiding this comment.
import IStaker.sol from the interface folder.
| StakerInterface staker = StakerInterface(stakerAddress); | ||
|
|
||
| // sender as the administrator | ||
| staker.createPool(tokenType, tokenAddress, tokenID, transferable, lockupSeconds, cooldownSeconds, msg.sender); |
There was a problem hiding this comment.
Can set msg.sender as null address in pool creation to reduce gas useage
mrk-hub
reviewed
Jan 27, 2025
| // sender as the administrator | ||
| staker.createPool(tokenType, tokenAddress, tokenID, transferable, lockupSeconds, cooldownSeconds, msg.sender); | ||
|
|
||
| // 0 address as the administrator to make the pool immutable |
There was a problem hiding this comment.
Unknown poolID Call will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the ImmutablePoolCreator contract in the terminus directory. It creates a staking pool on the Staker contract and transfers the administrator to the 0 address