Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#41 Add new GitHub Actions workflow to submit dependency tree samples #66

Merged
merged 2 commits into from
Oct 8, 2023
Merged

#41 Add new GitHub Actions workflow to submit dependency tree samples #66

merged 2 commits into from
Oct 8, 2023

Conversation

Monoradioactivo
Copy link
Contributor

@Monoradioactivo Monoradioactivo commented Oct 7, 2023

This PR adds a new GitHub Actions workflow that updates the dependency graph whenever there's a change to pom.xml in the main branch


steps:
- name: Checkout code
uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the latest version of actions/checkout, namely v4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please review.

Comment on lines 28 to 29
with:
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary, because the advanced-security/maven-dependency-submission-action defaults to using the GitHub token. Because it's the same as the default, please leave this part out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please review.

Copy link
Contributor

@rmgrimm rmgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the pull request, @Monoradioactivo !

@rmgrimm rmgrimm merged commit bb4605f into FwMotion:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants