-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs test #92
base: main
Are you sure you want to change the base?
docs test #92
Conversation
31f7216
to
1895438
Compare
c5844fd
to
1895438
Compare
34835ee
to
1895438
Compare
f0e57d6
to
74c41d5
Compare
- name: Clean previous builds | ||
working-directory: ./docs | ||
run: make clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need this? There's no previous builds and I don't see caching here
.github/workflows/docs.yml
Outdated
uses: actions/checkout@v3 | ||
with: | ||
ref: docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/checkout@v3 | |
with: | |
ref: docs | |
uses: actions/checkout@v4 |
- uses: actions/setup-python@v4 | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install sphinx sphinx_rtd_theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use setup-uv
, tool.uv
for dependencies, and uv sync
.github/workflows/docs.yml
Outdated
uses: peaceiris/actions-gh-pages@v3 | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
publish_branch: gh-pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publish_branch: gh-pages |
I don't think we need this
working-directory: ./docs | ||
run: make clean | ||
|
||
- name: Generate .rst files using sphinx-apidoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add support for GSM8k and HotPotQA
name: docs | ||
|
||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add workflow_dispatch
.github/workflows/docs.yml
Outdated
pull_request: | ||
branches: | ||
- main # Optional: build on pull requests to the main branch | ||
- docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request: | |
branches: | |
- main # Optional: build on pull requests to the main branch | |
- docs |
We won't PR into docs
and we already have push
on main
branch
No description provided.