Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👽️ PROCESS develop api changes #3636

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Oct 11, 2024

Description

Updates our PROCESS api for the current develop version of PROCESS.

Interface Changes

Many....
Still todo:

  • check for any leftover old variable names code wide
  • check process example
  • REVERT private data branch

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added enhancement New feature or request codes Tasks relating to integration of external codes upstream Issues related to upstream dependencies labels Oct 11, 2024
@je-cook je-cook requested a review from a team as a code owner October 11, 2024 15:15
@je-cook je-cook marked this pull request as draft October 11, 2024 15:15
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (815bb01) to head (6cf1e37).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/codes/process/model_mapping.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3636   +/-   ##
========================================
  Coverage    76.59%   76.59%           
========================================
  Files          230      230           
  Lines        27015    27043   +28     
========================================
+ Hits         20691    20713   +22     
- Misses        6324     6330    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-cook je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from f4c9acc to 346a6f1 Compare October 22, 2024 12:35
@je-cook je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from c349301 to f61bf02 Compare November 6, 2024 15:15
@je-cook je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from 38c12bd to f635b7c Compare November 18, 2024 12:51
Copy link
Contributor

github-actions bot commented Nov 25, 2024

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (3)

On runtest

  • /home/runner/work/bluemira/bluemira/bluemira/equilibria/find.py:478: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
  • /home/runner/work/bluemira/bluemira/bluemira/radiation_transport/radiation_tools.py:886: DeprecationWarning: interp2dis deprecated!interp2d` is deprecated in SciPy 1.10 and will be removed in SciPy 1.12.0.

For legacy code, nearly bug-for-bug compatible replacements are
RectBivariateSpline on regular grids, and bisplrep/bisplev for
scattered 2D data.

In new code, for regular grids use RegularGridInterpolator instead.
For scattered data, prefer LinearNDInterpolator or
CloughTocher2DInterpolator.

For more details see
https://gist.github.com/ev-br/8544371b40f414b7eaf3fe6217209bff
`

On config

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/pivy/quarter/QuarterWidget.py:17: DeprecationWarning: invalid escape sequence '\C'

@je-cook je-cook force-pushed the je-cook/process_develop branch from d28b570 to 259f809 Compare December 6, 2024 09:26
@je-cook je-cook force-pushed the je-cook/process_develop branch from f17a72c to eeada7e Compare January 8, 2025 09:38
@je-cook je-cook force-pushed the je-cook/process_develop branch from eeada7e to 1481cee Compare January 8, 2025 09:53
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codes Tasks relating to integration of external codes enhancement New feature or request upstream Issues related to upstream dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant