Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZIp vertical stability criterion #3606

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

RZIp vertical stability criterion #3606

wants to merge 5 commits into from

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Sep 13, 2024

Description

Adds the RZIp to the code along side some greens functions and inductance calculations

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the equilibria Tasks relating to the equilibria module label Sep 13, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Base automatically changed from je-cook/control_enforcement to develop September 19, 2024 09:23
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 41.50943% with 93 lines in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (815bb01) to head (801a4fc).

Files with missing lines Patch % Lines
bluemira/equilibria/vertical_stability.py 0.00% 54 Missing ⚠️
bluemira/equilibria/coils/_grouping.py 57.14% 12 Missing ⚠️
bluemira/equilibria/plasma.py 59.25% 11 Missing ⚠️
bluemira/equilibria/coils/_tools.py 66.66% 6 Missing ⚠️
bluemira/equilibria/equilibrium.py 60.00% 4 Missing ⚠️
bluemira/equilibria/coils/_coil.py 75.00% 2 Missing ⚠️
bluemira/equilibria/coils/_field.py 77.77% 2 Missing ⚠️
bluemira/equilibria/plotting.py 0.00% 1 Missing ⚠️
bluemira/magnetostatics/greens.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3606      +/-   ##
===========================================
- Coverage    76.59%   76.36%   -0.23%     
===========================================
  Files          230      231       +1     
  Lines        27015    27145     +130     
===========================================
+ Hits         20691    20729      +38     
- Misses        6324     6416      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@je-cook je-cook force-pushed the je-cook/vert_stab branch 2 times, most recently from eb9108a to e2d47b4 Compare December 2, 2024 11:59
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
equilibria Tasks relating to the equilibria module
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant