-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pyclipper -> pyclipr #3375
Draft
oliverfunk
wants to merge
8
commits into
develop
Choose a base branch
from
oliverfunk/3197-Look-into-clipper-2-and-pyclipr-as-a-pyclipper-upgrade
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: pyclipper -> pyclipr #3375
oliverfunk
wants to merge
8
commits into
develop
from
oliverfunk/3197-Look-into-clipper-2-and-pyclipr-as-a-pyclipper-upgrade
+247
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 problems:
also: |
Cool! how do you feel about the package, good change? |
je-cook
added
geometry
Tasks relating to the geometry module
enhancement
New feature or request
labels
Jun 24, 2024
oliverfunk
force-pushed
the
oliverfunk/3197-Look-into-clipper-2-and-pyclipr-as-a-pyclipper-upgrade
branch
from
June 28, 2024 15:19
8a2ec75
to
d6dc520
Compare
I've realised after testing, this seemingly cannot do negative offsets. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Tasks that are blocked
enhancement
New feature or request
geometry
Tasks relating to the geometry module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #3197
Description
Moves to the new pyclipr package based on Clipper2 for the fallback offsetting library.
Interface Changes
None, only internal api's.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
pre-commit run --from-ref develop --to-ref HEAD
sphinx-build -W documentation/source documentation/build