Add screenshots to front page carousel #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Sørlie Glomsaas <[email protected]>
UncleClapton
requested changes
Nov 5, 2024
There was a problem hiding this comment.
If we want new images, fine, but the intention was never to just continue adding.
If we want a new rotation, replace the old set with a new set of the same count, or implement a way for there to be a subset of a larger list which rotates at an interval (maybe a daily one).
In any event, I don't want this to continue expanding infinitely. all of these images are pre-loaded onto the user's machine in the background, and the UI gets more cluttered with the image picker the more you add. Stick to 5-8 at a time
Comment on lines
+98
to
134
| function FuelRatsHome(props) { | ||
| const { authenticate, ...restQuery } = props.query | ||
| const dispatch = useDispatch() | ||
|
|
||
| useEffect(() => { | ||
| if (authenticate) { | ||
| dispatch(setFlag('showLoginDialog', true)) | ||
| Router.replace(makeRoute('/', restQuery), undefined, { shallow: true }) | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- only run on authenticate change, we only care about the state of others when this value changes anyway. | ||
| }, [authenticate]) | ||
|
|
||
| return ( | ||
| <section className="hero"> | ||
| <Carousel id="HomeImages" slides={CarouselSlides} /> | ||
|
|
||
| <header> | ||
| <h1>{'We Have Fuel. '}<wbr />{"You\u00a0Don't."}</h1> | ||
| <h2>{'Any Questions?'}</h2> | ||
| </header> | ||
|
|
||
| <footer className="call-to-action"> | ||
| <Link href="/i-need-fuel"> | ||
| <a className="button tall">{'Get Fuel'}</a> | ||
| </Link> | ||
| </footer> | ||
| </section> | ||
| ) | ||
| } | ||
|
|
||
| FuelRatsHome.getPageMeta = () => { | ||
| return { | ||
| noHeader: true, | ||
| title: 'Home', | ||
| key: 'home', | ||
| } | ||
| return { | ||
| noHeader: true, | ||
| title: 'Home', | ||
| key: 'home', | ||
| } | ||
| } |
There was a problem hiding this comment.
Please revert these indentation changes. I think your editor squeaked this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #[issue]
Changelog
✨ Additions
Additional Information
Contributor's Checklist
yarn lintand confirmed there are no errors or warnings.CONTRIBUTING.md.Maintainer's Checklist
CHANGELOG.md.