-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update internally used chain config #3420
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhaiwat10 will the differences between the local
and ignition
chains cause issues here? Consensus parameters version for local
is V2
and for ignition
(and other configs) it is V1
.
@petertonysmith94 That's a good point. I'm not really sure which one we are supposed to use. I heard from one of the team members that apparently the local config specified by them hasn't been updated in a long time. I'm not sure why the local is Gonna try a few things and get back with some more context for our sync. |
It seems our local test chain config uses settings from the Testnet upgrade number 6 Maybe we should go for either the latest Testnet upgrade (upgrade number 9) or even the lastest Mainet Upgrade Both of them seem to be using the This will require changes only on our side if I am not mistaken, and only on TS types related to test helpers. It seems that even though these versions are being updated on the chain config JSON for main-net and test-net, fuel-core always resolves them to |
… into dp/update-chain-config
@Torres-ssf can you check the changes I made and if they make sense? |
CodSpeed Performance ReportMerging #3420 will degrade performances by 54.42%Comparing Summary
Benchmarks breakdown
|
Summary
This PR updates our internally used chain config to match the one specified here
Checklist