Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update internally used chain config #3420

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Nov 25, 2024

Summary

This PR updates our internally used chain config to match the one specified here

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Nov 25, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 10:22am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 10:22am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 10:22am

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhaiwat10 will the differences between the local and ignition chains cause issues here? Consensus parameters version for local is V2 and for ignition (and other configs) it is V1.

@Dhaiwat10
Copy link
Member Author

@petertonysmith94 That's a good point. I'm not really sure which one we are supposed to use. I heard from one of the team members that apparently the local config specified by them hasn't been updated in a long time. I'm not sure why the local is V2 and not mainnet, either.

Gonna try a few things and get back with some more context for our sync.

@Torres-ssf
Copy link
Contributor

Torres-ssf commented Nov 25, 2024

It seems our local test chain config uses settings from the Testnet upgrade number 6

Maybe we should go for either the latest Testnet upgrade (upgrade number 9) or even the lastest Mainet Upgrade

Both of them seem to be using the V2 for consensus_parameters already.

This will require changes only on our side if I am not mistaken, and only on TS types related to test helpers.

It seems that even though these versions are being updated on the chain config JSON for main-net and test-net, fuel-core always resolves them to V1 when returning the response for the graphQL queries. I believe this is due to backward compatibility reasons.

Screenshot 2024-11-25 at 10 57 01 AM Screenshot 2024-11-25 at 10 56 48 AM

@Dhaiwat10
Copy link
Member Author

@Torres-ssf can you check the changes I made and if they make sense?

Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #3420 will degrade performances by 54.42%

Comparing dp/update-chain-config (d65bcf3) with master (ef94263)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dp/update-chain-config Change
should successfully transfer a single asset between wallets (x20 times) 61.5 ms 134.9 ms -54.42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update internally used Chain Config
4 participants