[pkg/sitemap-ext]: Fixes handling of projects with a base with a trailing slash #61

Fryuni · 2024-03-27T00:16:34Z

No description provided.

vercel · 2024-03-27T00:16:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
inox-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 11:04am

Fryuni · 2024-03-27T00:17:02Z

/snapshot base-trailing-slash

github-actions · 2024-03-27T00:18:25Z

Snapshots have been released for the following packages:

@inox-tools/aik-route-config@pr--base-trailing-slash
@inox-tools/sitemap-ext@pr--base-trailing-slash
@example/sitemap-ext@pr--base-trailing-slash

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the pr--base-trailing-slash tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @inox-tools/aik-mod
🦋  info npm info @inox-tools/aik-route-config
🦋  info npm info @inox-tools/custom-routing
🦋  info npm info @inox-tools/inline-mod
🦋  info npm info @inox-tools/sitemap-ext
🦋  info npm info @inox-tools/velox-luna
🦋  warn @inox-tools/aik-mod is not being published because version 0.4.0 is already published on npm
🦋  info @inox-tools/aik-route-config is being published because our local version (0.0.0-base-trailing-slash-20240327001804) has not been published on npm
🦋  warn @inox-tools/custom-routing is not being published because version 0.2.1 is already published on npm
🦋  warn @inox-tools/inline-mod is not being published because version 1.3.1 is already published on npm
🦋  info @inox-tools/sitemap-ext is being published because our local version (0.0.0-base-trailing-slash-20240327001804) has not been published on npm
🦋  warn @inox-tools/velox-luna is not being published because version 0.2.0 is already published on npm
🦋  info Publishing "@inox-tools/aik-route-config" at "0.0.0-base-trailing-slash-20240327001804"
🦋  info Publishing "@inox-tools/sitemap-ext" at "0.0.0-base-trailing-slash-20240327001804"
🦋  success packages published successfully:
🦋  @inox-tools/[email protected]
🦋  @inox-tools/[email protected]
🦋  Creating git tags...
🦋  New tag:  @inox-tools/[email protected]
🦋  New tag:  @inox-tools/[email protected]

Build Log


> [email protected] build /home/runner/work/inox-tools/inox-tools
> turbo run --filter '@inox-tools/*' build

• Packages in scope: @inox-tools/aik-mod, @inox-tools/aik-route-config, @inox-tools/custom-routing, @inox-tools/inline-mod, @inox-tools/sitemap-ext, @inox-tools/velox-luna
• Running build in 6 packages
• Remote caching disabled
::group::@inox-tools/custom-routing:build
cache hit, suppressing logs 0ca0431b4407aa96
::endgroup::
::group::@inox-tools/inline-mod:build
cache hit, suppressing logs f5eec5c9f8a855cb
::endgroup::
::group::@inox-tools/aik-mod:build
cache hit, suppressing logs 1e502b13ed4b19cb
::endgroup::
::group::@inox-tools/velox-luna:build
cache hit, suppressing logs bcce0bd79bacbb06
::endgroup::
::group::@inox-tools/aik-route-config:build
cache miss, executing 0d3c26e64a090fc5

> @inox-tools/[email protected] build /home/runner/work/inox-tools/inox-tools/packages/aik-route-config
> tsup

CLI Building entry: src/index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v8.0.2
CLI Using tsup config: /home/runner/work/inox-tools/inox-tools/packages/aik-route-config/tsup.config.ts
CLI Target: node18
CLI Cleaning output folder
ESM Build start
ESM dist/index.js     9.80 KB
ESM dist/index.js.map 18.80 KB
ESM ⚡️ Build success in 106ms
DTS Build start
DTS ⚡️ Build success in 2675ms
DTS dist/index.d.ts 567.00 B
::endgroup::
::group::@inox-tools/sitemap-ext:build
cache miss, executing d84e8615b004e27a

> @inox-tools/[email protected] build /home/runner/work/inox-tools/inox-tools/packages/sitemap-ext
> tsup

CLI Building entry: index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v8.0.2
CLI Using tsup config: /home/runner/work/inox-tools/inox-tools/packages/sitemap-ext/tsup.config.ts
CLI Target: node18
CLI Cleaning output folder
ESM Build start
ESM dist/index.js     5.00 KB
ESM dist/index.js.map 9.24 KB
ESM ⚡️ Build success in 79ms
DTS Build start
DTS ⚡️ Build success in 2397ms
DTS dist/index.d.ts 566.00 B
::endgroup::

 Tasks:    6 successful, 6 total
Cached:    4 cached, 6 total
  Time:    7.512s

Fryuni · 2024-03-27T01:24:08Z

/snapshot base-trailing-slash

github-actions · 2024-03-27T01:24:58Z

Snapshots have been released for the following packages:

@inox-tools/aik-route-config@pr--base-trailing-slash
@inox-tools/sitemap-ext@pr--base-trailing-slash
@example/sitemap-ext@pr--base-trailing-slash

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the pr--base-trailing-slash tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @inox-tools/aik-mod
🦋  info npm info @inox-tools/aik-route-config
🦋  info npm info @inox-tools/custom-routing
🦋  info npm info @inox-tools/inline-mod
🦋  info npm info @inox-tools/sitemap-ext
🦋  info npm info @inox-tools/velox-luna
🦋  warn @inox-tools/aik-mod is not being published because version 0.4.0 is already published on npm
🦋  info @inox-tools/aik-route-config is being published because our local version (0.0.0-base-trailing-slash-20240327012437) has not been published on npm
🦋  warn @inox-tools/custom-routing is not being published because version 0.2.1 is already published on npm
🦋  warn @inox-tools/inline-mod is not being published because version 1.3.1 is already published on npm
🦋  info @inox-tools/sitemap-ext is being published because our local version (0.0.0-base-trailing-slash-20240327012437) has not been published on npm
🦋  warn @inox-tools/velox-luna is not being published because version 0.2.0 is already published on npm
🦋  info Publishing "@inox-tools/aik-route-config" at "0.0.0-base-trailing-slash-20240327012437"
🦋  info Publishing "@inox-tools/sitemap-ext" at "0.0.0-base-trailing-slash-20240327012437"
🦋  success packages published successfully:
🦋  @inox-tools/[email protected]
🦋  @inox-tools/[email protected]
🦋  Creating git tags...
🦋  New tag:  @inox-tools/[email protected]
🦋  New tag:  @inox-tools/[email protected]

Build Log


> [email protected] build /home/runner/work/inox-tools/inox-tools
> turbo run --filter '@inox-tools/*' build

• Packages in scope: @inox-tools/aik-mod, @inox-tools/aik-route-config, @inox-tools/custom-routing, @inox-tools/inline-mod, @inox-tools/sitemap-ext, @inox-tools/velox-luna
• Running build in 6 packages
• Remote caching enabled
::group::@inox-tools/custom-routing:build
cache hit, suppressing logs 0ca0431b4407aa96
::endgroup::
::group::@inox-tools/inline-mod:build
cache hit, suppressing logs f5eec5c9f8a855cb
::endgroup::
::group::@inox-tools/aik-mod:build
cache hit, suppressing logs 1e502b13ed4b19cb
::endgroup::
::group::@inox-tools/velox-luna:build
cache hit, suppressing logs bcce0bd79bacbb06
::endgroup::
::group::@inox-tools/aik-route-config:build
cache miss, executing 93d9b00a9a2c5985

> @inox-tools/[email protected] build /home/runner/work/inox-tools/inox-tools/packages/aik-route-config
> tsup

CLI Building entry: src/index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v8.0.2
CLI Using tsup config: /home/runner/work/inox-tools/inox-tools/packages/aik-route-config/tsup.config.ts
CLI Target: node18
CLI Cleaning output folder
ESM Build start
ESM dist/index.js     9.80 KB
ESM dist/index.js.map 18.80 KB
ESM ⚡️ Build success in 131ms
DTS Build start
DTS ⚡️ Build success in 2619ms
DTS dist/index.d.ts 567.00 B
::endgroup::
::group::@inox-tools/sitemap-ext:build
cache miss, executing 36d2eeef57561fef

> @inox-tools/[email protected] build /home/runner/work/inox-tools/inox-tools/packages/sitemap-ext
> tsup

CLI Building entry: index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v8.0.2
CLI Using tsup config: /home/runner/work/inox-tools/inox-tools/packages/sitemap-ext/tsup.config.ts
CLI Target: node18
CLI Cleaning output folder
ESM Build start
ESM dist/index.js     5.24 KB
ESM dist/index.js.map 9.68 KB
ESM ⚡️ Build success in 85ms
DTS Build start
DTS ⚡️ Build success in 2408ms
DTS dist/index.d.ts 566.00 B
::endgroup::

 Tasks:    6 successful, 6 total
Cached:    4 cached, 6 total
  Time:    8.044s

Adammatthiesen

Worked great to resolve all the issues with SSR and Slugged pages.

Only other "non-related" bug to resolve, is the sitemap duplication bug from both sitemap integrations outputting

…ling slash

github-actions bot added pkg/sitemap-ext pkg/aik-route-config labels Mar 27, 2024

vercel bot deployed to Preview March 27, 2024 01:24 View deployment

Adammatthiesen approved these changes Mar 27, 2024

View reviewed changes

Fryuni added 3 commits March 27, 2024 08:04

[pkg/sitemap-ext]: Fixes handling of projects with a base with a trai…

95e2e6d

…ling slash

[pkg/aik-route-config]: Adds a log message on SSR import errors

7e93e79

[pkg/sitemap-ext]: Fix static SSR pages double entries

9a9fd73

Fryuni force-pushed the fix/sitemap-base-root branch from fca3860 to 9a9fd73 Compare March 27, 2024 11:04

vercel bot deployed to Preview March 27, 2024 11:04 View deployment

Fryuni enabled auto-merge (rebase) March 27, 2024 11:05

Fryuni merged commit a1c57c9 into main Mar 27, 2024
11 checks passed

Fryuni deleted the fix/sitemap-base-root branch March 27, 2024 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pkg/sitemap-ext]: Fixes handling of projects with a base with a trailing slash #61

[pkg/sitemap-ext]: Fixes handling of projects with a base with a trailing slash #61

Fryuni commented Mar 27, 2024

vercel bot commented Mar 27, 2024 •

edited

Loading

Fryuni commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Fryuni commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Adammatthiesen left a comment

[pkg/sitemap-ext]: Fixes handling of projects with a base with a trailing slash #61

[pkg/sitemap-ext]: Fixes handling of projects with a base with a trailing slash #61

Conversation

Fryuni commented Mar 27, 2024

vercel bot commented Mar 27, 2024 • edited Loading

Fryuni commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Fryuni commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Adammatthiesen left a comment

Choose a reason for hiding this comment

vercel bot commented Mar 27, 2024 •

edited

Loading