Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] release #183

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[ci] release #183

merged 1 commit into from
Dec 10, 2024

Conversation

Fryuni
Copy link
Owner

@Fryuni Fryuni commented Dec 10, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@inox-tools/[email protected]

Minor Changes

  • 4870d82: Fixes flash of page with unsynchronized state due to response streaming.

@inox-tools/[email protected]

Patch Changes

  • f2e76e2: Refactor internally to use new Inox Tools template

@inox-tools/[email protected]

Patch Changes

Summary by CodeRabbit

  • New Features

    • Updated version for @inox-tools/custom-routing to 1.0.2.
    • Updated version for @inox-tools/request-nanostores to 0.2.1.
    • Updated version for @inox-tools/request-state to 0.3.0.
  • Bug Fixes

    • Addressed synchronization issues during response streaming in @inox-tools/request-state.
  • Documentation

    • Changelogs updated for @inox-tools/custom-routing, @inox-tools/request-nanostores, and @inox-tools/request-state.
  • Style

    • Improved code formatting for better readability in @inox-tools/custom-routing.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inox-tools ✅ Ready (Inspect) Visit Preview Dec 10, 2024 1:42am

Copy link

coderabbitai bot commented Dec 10, 2024

Walkthrough

This pull request includes a refactor of the @inox-tools/custom-routing package, which involves the removal of an outdated patch and updates to the versioning and changelog. The version of the package is incremented from 1.0.1 to 1.0.2, reflecting an internal refactor to align with a new Inox Tools template. Additionally, formatting changes have been made in the source code to improve readability without altering any functionality. The @inox-tools/request-nanostores and @inox-tools/request-state packages also received version updates and changelog modifications.

Changes

File Change Summary
.changeset/gentle-kids-worry.md Deleted file containing a patch for @inox-tools/custom-routing, indicating the patch is no longer necessary.
packages/custom-routing/CHANGELOG.md Updated changelog to include version 1.0.2, detailing internal refactor and previous changes from version 1.0.1.
packages/custom-routing/package.json Updated package version from 1.0.1 to 1.0.2.
packages/custom-routing/src/index.ts Formatting and indentation changes for properties and return statements; no logical changes to functions or type definitions.
packages/request-nanostores/CHANGELOG.md Updated changelog to include version 0.2.1, detailing dependency update for @inox-tools/request-state.
packages/request-nanostores/package.json Updated package version from 0.2.0 to 0.2.1.
packages/request-state/CHANGELOG.md Updated changelog to include version 0.3.0, detailing a minor change related to state synchronization during response streaming.
packages/request-state/package.json Updated package version from 0.2.0 to 0.3.0.

Possibly related PRs

  • feat(custom-routing): Refactor internally to use new template #182: The main PR involves a refactor of the @inox-tools/custom-routing package to utilize a new Inox Tools template, which directly relates to the changes made in the packages/custom-routing files, including the removal of the old routing functionality and the introduction of new routing methods.

Suggested labels

pkg/request-state

Suggested reviewers

  • Fryuni
  • BryceRussell
  • OliverSpeir

🐰 In the code where rabbits hop,
A patch was tossed, it couldn't stop.
With version bumped and format neat,
The routing's now a tidy feat!
So let us cheer, with joyful glee,
For clean code is the way to be! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c6fa43d and f776e10.

📒 Files selected for processing (8)
  • .changeset/gentle-kids-worry.md (0 hunks)
  • packages/custom-routing/CHANGELOG.md (1 hunks)
  • packages/custom-routing/package.json (1 hunks)
  • packages/custom-routing/src/index.ts (1 hunks)
  • packages/request-nanostores/CHANGELOG.md (1 hunks)
  • packages/request-nanostores/package.json (1 hunks)
  • packages/request-state/CHANGELOG.md (1 hunks)
  • packages/request-state/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/gentle-kids-worry.md
✅ Files skipped from review due to trivial changes (3)
  • packages/request-nanostores/package.json
  • packages/request-state/package.json
  • packages/request-nanostores/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/custom-routing/package.json
  • packages/custom-routing/CHANGELOG.md
  • packages/custom-routing/src/index.ts
🔇 Additional comments (2)
packages/request-state/CHANGELOG.md (2)

3-8: LGTM! The changelog entry is well-structured and accurate.

The new version entry correctly documents the minor change with proper semantic versioning and follows the Changesets format consistently.


7-7: Verify the referenced commit.

Let's verify that the referenced commit hash exists and contains the described changes.

✅ Verification successful

The commit hash 4870d82 exists in the repository and matches the changelog entry. The commit message "fix(request-state): remove data race on early state load (#179)" aligns with the changelog description about fixing "flash of page with unsynchronized state due to response streaming."

Let me verify the actual code changes to ensure they match the changelog description:


Let me verify the code changes related to the request-state package to confirm the fix for the flash of unsynchronized state:


Let me verify the changes in the client-side state handling code to understand how the flash of unsynchronized state was fixed:


Commit hash verified and changes confirm the fix for flash of unsynchronized state

The commit 4870d82 implements a fix for the flash of unsynchronized state by:

  1. Loading the state immediately when the document loads
  2. Properly handling state transitions during view transitions by capturing the next state before the swap
  3. Using a custom event ServerStateLoaded to provide a hook for state changes
  4. Ensuring state is cleared and repopulated atomically to prevent intermediate states

The changes match the changelog entry and effectively address the issue of unsynchronized state during response streaming.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the commit hash and its changes

# Check if the commit exists and show its changes
git show 4870d82 --stat

Length of output: 38754


Script:

#!/bin/bash
# Get the actual code changes in the commit
git show 4870d82 --unified=3

Length of output: 69644


Script:

#!/bin/bash
# Search for changes in request-state package
git show 4870d82 -- 'packages/request-state/*'

Length of output: 30267


Script:

#!/bin/bash
# Search for the client-side state handling code
git show 4870d82 -- 'packages/request-state/src/runtime/clientState.ts'

Length of output: 2076


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot force-pushed the changeset-release/main branch from c6fa43d to f776e10 Compare December 10, 2024 01:41
@Fryuni Fryuni merged commit f0c97fd into main Dec 10, 2024
2 checks passed
@Fryuni Fryuni deleted the changeset-release/main branch December 10, 2024 01:43
This was referenced Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant