Neopixel_caselight_enable

[Benoitone]

if no toolhead light is selected in printer.cfg and only one of the 2 types of neopixel caselight is included then no lighting will be active in the macros.

[Frix-x]

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

[Benoitone]

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

Hello, I don't really see the point of adding a variable in variables.cfg...
For me, the modification made solves the problem encountered and seems to me to be entirely compatible with the different possible configurations.

[Benoitone]

@Frix-x @mattpolito maybe we can make a common PR with #563 :
If @mattpolito want to make is PR modified in neopixel_caselight_enable branch??? with:

[gcode_macro _INIT_LEDS]
gcode:
    {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled or printer["gcode_macro _USER_VARIABLES"].light_enabled %}
        {% if printer["gcode_macro _USER_VARIABLES"].caselight_on_at_startup|default(False) %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_ON
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="READY"
            {% endif %}
        {% else %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_OFF
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="OFF"
            {% endif %}
        {% endif %}
    {% endif %}

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[github-actions]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

[Frix-x]

Ok, so I just merged #563
Now that I'm back on the topic, let's try to get this solved and merged :)