[TASK] Switch Documentation Rendering to PHP #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
reviewed
Oct 13, 2024
| run: | | ||
| mkdir -p Documentation-GENERATED-temp \ | ||
| && docker run --rm --pull always -v $(pwd):/project \ | ||
| ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log |
There was a problem hiding this comment.
Suggested change
| ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log | |
| ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --minimal-test |
linawolf
reviewed
Oct 13, 2024
Documentation/guides.xml
Outdated
| project-issues="https://github.com/FriendsOfTYPO3/introduction/issues" | ||
| edit-on-github-branch="main" | ||
| edit-on-github="FriendsOfTYPO3/introduction" | ||
| typo3-core-preferred="stable" |
There was a problem hiding this comment.
Suggested change
| typo3-core-preferred="stable" | |
| typo3-core-preferred="main" |
linawolf
reviewed
Oct 13, 2024
Documentation/guides.xml
Outdated
Comment on lines
21
to
22
| /> | ||
| <inventory id="t3coreapi" | ||
| url="https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/" | ||
| /> | ||
| <inventory id="t3install" | ||
| url="https://docs.typo3.org/m/typo3/tutorial-getting-started/main/en-us/" | ||
| /> | ||
| </guides> |
There was a problem hiding this comment.
Suggested change
| /> | |
| <inventory id="t3coreapi" | |
| url="https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/" | |
| /> | |
| <inventory id="t3install" | |
| url="https://docs.typo3.org/m/typo3/tutorial-getting-started/main/en-us/" | |
| /> | |
| </guides> | |
| /> | |
| </guides> |
linawolf
reviewed
Oct 13, 2024
Makefile
Outdated
| .PHONY: test-docs | ||
| test-docs: ## Test the documentation rendering | ||
| mkdir -p Documentation-GENERATED-temp | ||
| docker run --rm --pull always -v "$(shell pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log |
There was a problem hiding this comment.
Suggested change
| docker run --rm --pull always -v "$(shell pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log | |
| docker run --rm --pull always -v "$(shell pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --minimal-test |
|
Thanks a lot for taking care of this! Just some small remarks |
linawolf
reviewed
Oct 13, 2024
.idea/.gitignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
Please delete the .idea folder from your PR: It is for local development only and should not be commited.
Best add it to the .gitignore instead
Alagts
force-pushed
the
task/rendering
branch
from
150e5e4 to
73455ee
Compare
Resolves: FriendsOfTYPO3#112 Releases: main
Alagts
force-pushed
the
task/rendering
branch
from
73455ee to
6175756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can try out the rendering locally with
Resolves: #112