Merge pull request #282 from vasilvestre/enable-spec

Enable spec
FriendsOfSylius · Dec 21, 2022 · 5d9b00b · 5d9b00b
2 parents 05375a2 + b3e31ff
commit 5d9b00b
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 10 deletions.
diff --git a/spec/Exporter/ResourceExporterSpec.php b/spec/Exporter/ResourceExporterSpec.php
@@ -40,7 +40,7 @@ function it_should_export_but_also_transform(
         PluginInterface $plugin
     ) {
         $generator = new RewindableGenerator(function () {
-            return [new DateTimeToStringHandler()];
+            yield new DateTimeToStringHandler();
         }, $count = 1);
 
         $pool = new Pool($generator);

diff --git a/spec/Exporter/Transformer/Handler/ArrayToStringHandlerSpec.php b/spec/Exporter/Transformer/Handler/ArrayToStringHandlerSpec.php
@@ -41,7 +41,7 @@ function it_should_process_via_pool()
         $array = ['a', 'b', 'c'];
 
         $generator = new RewindableGenerator(function () {
-            return [$this->getWrappedObject()];
+            yield $this->getWrappedObject();
         }, $count = 1);
 
         $pool = new Pool($generator);

diff --git a/spec/Exporter/Transformer/Handler/DateTimeToStringHandlerSpec.php b/spec/Exporter/Transformer/Handler/DateTimeToStringHandlerSpec.php
@@ -41,7 +41,7 @@ function it_should_process_via_pool()
         $date = \DateTime::createFromFormat('Y-m-d', '2018-01-01');
 
         $generator = new RewindableGenerator(function () {
-            return [$this->getWrappedObject()];
+            yield $this->getWrappedObject();
         }, $count = 1);
 
         $pool = new Pool($generator);

diff --git a/spec/Exporter/Transformer/Handler/IntegerToMoneyFormatHandlerSpec.php b/spec/Exporter/Transformer/Handler/IntegerToMoneyFormatHandlerSpec.php
@@ -9,6 +9,7 @@
 use FriendsOfSylius\SyliusImportExportPlugin\Exporter\Transformer\HandlerInterface;
 use FriendsOfSylius\SyliusImportExportPlugin\Exporter\Transformer\Pool;
 use PhpSpec\ObjectBehavior;
+use Prophecy\Prophet;
 use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
 use Webmozart\Assert\Assert;
 
@@ -38,12 +39,13 @@ function it_should_process_directly()
     {
         $this->handle('test', 10000)->shouldBeString();
         $this->handle('test', 12345)->shouldBe('123.45');
+        $this->handle('test', 987654)->shouldBe('9876.54');
     }
 
     function it_should_process_via_pool()
     {
         $generator = new RewindableGenerator(function () {
-            return [$this->getWrappedObject()];
+            yield $this->getWrappedObject();
         }, $count = 1);
 
         $pool = new Pool($generator);

diff --git a/spec/Exporter/Transformer/PoolSpec.php b/spec/Exporter/Transformer/PoolSpec.php
@@ -24,8 +24,8 @@ function it_should_implement_interface()
 
     function let(HandlerInterface $dateTimeToStringHandler)
     {
-        $generator = new RewindableGenerator(function () use ($dateTimeToStringHandler) {
-            return [$dateTimeToStringHandler];
+        $generator = new RewindableGenerator(function () use ($dateTimeToStringHandler): \Traversable {
+            yield $dateTimeToStringHandler;
         }, $count = 1);
 
         $this->beConstructedWith($generator);

diff --git a/spec/Importer/JsonResourceImporterSpec.php b/spec/Importer/JsonResourceImporterSpec.php
@@ -4,7 +4,7 @@
 
 namespace spec\FriendsOfSylius\SyliusImportExportPlugin\Importer;
 
-use Doctrine\Common\Persistence\ObjectManager;
+use Doctrine\Persistence\ObjectManager;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\ImporterResultInterface;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\ImportResultLoggerInterface;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\JsonResourceImporter;

diff --git a/spec/Importer/ResourceImporterSpec.php b/spec/Importer/ResourceImporterSpec.php
@@ -4,7 +4,7 @@
 
 namespace spec\FriendsOfSylius\SyliusImportExportPlugin\Importer;
 
-use Doctrine\Common\Persistence\ObjectManager;
+use Doctrine\Persistence\ObjectManager;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\ImporterInterface;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\ImporterResultInterface;
 use FriendsOfSylius\SyliusImportExportPlugin\Importer\ImportResultLoggerInterface;

diff --git a/src/Exporter/Transformer/Handler/IntegerToMoneyFormatHandler.php b/src/Exporter/Transformer/Handler/IntegerToMoneyFormatHandler.php
@@ -17,7 +17,7 @@ final class IntegerToMoneyFormatHandler extends Handler
     /**
      * @param string[] $allowedKeys
      */
-    public function __construct(array $allowedKeys, string $format = '%.2n')
+    public function __construct(array $allowedKeys, string $format = '%0.2f')
     {
         $this->keys = $allowedKeys;
         $this->format = $format;
@@ -28,7 +28,7 @@ public function __construct(array $allowedKeys, string $format = '%.2n')
      */
     protected function process($key, $value): ?string
     {
-        return money_format($this->format, $value / 100);
+        return sprintf($this->format, $value / 100);
     }
 
     protected function allows($key, $value): bool