Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix by Adding Empty String Check for Secret / Password #108

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix by Adding Empty String Check for Secret / Password #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99846cb
Update Maintenance.php
alxndr-w Aug 18, 2024
65eeaf4
Merge branch 'main' into fix-empty-string-check
alxndr-w Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Maintenance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public static function isSecretAllowed(): bool
$addon = rex_addon::get('maintenance');

// Bereits mit richtigem Secret eingeloggt
if (rex_session('maintenance_secret', 'string', '') === strval($addon->getConfig('maintenance_secret'))) { // @phpstan-ignore-line
if (rex_session('maintenance_secret', 'string', '') !== '' && rex_session('maintenance_secret', 'string', '') === strval($addon->getConfig('maintenance_secret'))) { // @phpstan-ignore-line
return true;
}

Expand Down