8.x - Fix afterDelete expecting an UploadedFileInterface object.
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #603 +/- ##
============================================
- Coverage 95.86% 95.84% -0.02%
Complexity 109 109
============================================
Files 11 11
Lines 290 289 -1
============================================
- Hits 278 277 -1
Misses 12 12
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts some of #593. The entity read from the DB will not hold uploaded file instances.
ps. I don't have time for it right now, but seeing how this slipped in, the tests are IMHO in dire need of de-mocking. There's so much mocking going on that could possibly hide all sorts of problems, it's wild.
Previously there was for example
$this->entity->fieldbeing set and passed to expectations, but it was alwaysnull, because it's all mocked, still the tests passed because there were no type hints on the arguments where the value would flow through.