Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md third-party extensions #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rambomst
Copy link

Added a third-party extension to the list for custom user stylesheets.

Added a third-party extension to the list for custom user stylesheets.
@Alkarex
Copy link
Member

Alkarex commented Nov 29, 2024

Hello,
Isn't it the same than the built-in core extension "User CSS"?
https://github.com/FreshRSS/FreshRSS/tree/edge/lib/core-extensions/UserCSS

See also #256

@Rambomst
Copy link
Author

Hello,
Isn't it the same than the built-in core extension "User CSS"?
https://github.com/FreshRSS/FreshRSS/tree/edge/lib/core-extensions/UserCSS

See also #256

Similar but not the same.

@Alkarex
Copy link
Member

Alkarex commented Nov 29, 2024

Similar but not the same.

Can you please briefly describe the differences?

@Rambomst
Copy link
Author

Rambomst commented Nov 29, 2024

The default extension allows the user to define internal CSS via a textarea, it comes a hassle to edit when you get 1000+ lines.

I wanted to be able to have a stylesheet that was easily openable within an IDE that gives context highlighting etc.

The extension I added allows the user to define the location of an external stylesheet.

edit

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

@Frenzie
Copy link
Member

Frenzie commented Nov 29, 2024

The extension isn't set in stone of course. I think it would welcome the ability to provide a URL as well. :-)

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

The extension doesn't do anything with @import. That's simply regular browser caching based on HTTP headers.

@Rambomst
Copy link
Author

The extension isn't set in stone of course. I think it would welcome the ability to provide a URL as well. :-)

If there is interest in this change then I am happy to open a PR to the core extension. Please let me know :)

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

The extension doesn't do anything with @import. That's simply regular browser caching based on HTTP headers.

I performed a hard refresh, I thought that would have busted all the cache related things, no?

@Frenzie
Copy link
Member

Frenzie commented Nov 29, 2024

I performed a hard refresh, I thought that would have busted all the cache related things, no?

My point is that the extension doesn't do any kind of processing. What goes in is what comes out with a Content-Type: text/css header, and a Last-Modified header indicating whenever you last clicked update. There isn't anything else to it.

Anything under @import is dealt with however @import is dealt with. My primary suspect in what you say is that this also means it doesn't add any CSP headers.

@Rambomst
Copy link
Author

I have opened a PR to FreshRSS which introduces this setting to the core UserCSS extension.

FreshRSS/FreshRSS#7107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants