Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readeck Button to README #245

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add Readeck Button to README #245

merged 1 commit into from
Aug 5, 2024

Conversation

Joedmin
Copy link
Contributor

@Joedmin Joedmin commented Aug 4, 2024

Hello, I've created a new extention called Readeck Button and would love to show it to the world

@Alkarex
Copy link
Member

Alkarex commented Aug 5, 2024

Hello,
You could consider adding a line for your extension to https://github.com/FreshRSS/Extensions/blob/master/repositories.json
so that it gets shown inside FreshRSS along version updates.

@Joedmin Joedmin requested a review from Frenzie August 5, 2024 11:21
@Alkarex Alkarex merged commit 474e27f into FreshRSS:master Aug 5, 2024
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Aug 5, 2024

@Joedmin You could consider updating the automated tests for your extension, on the model of the tests in https://github.com/FreshRSS/Extensions/tree/master to catch warnings, deprecations, etc. In particular PHPStan.

image

@Joedmin
Copy link
Contributor Author

Joedmin commented Aug 5, 2024

Thank you for your tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants