Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] for xExtension-ColorfulList: JavaScript error on pages that have no feed articles #187 #188

Merged
merged 16 commits into from
Nov 25, 2023

Conversation

shinemoon
Copy link
Contributor

Add pre-check/skip while not in the main page (e.g. configure page and so on) where no valid list will be loaded to avoid annoying error prints....

[Bug] xExtension-ColorfulList: JavaScript error on pages that have no feed articles

@shinemoon shinemoon marked this pull request as draft November 25, 2023 15:54
@shinemoon shinemoon marked this pull request as ready for review November 25, 2023 16:22
@Alkarex Alkarex merged commit a09223b into FreshRSS:master Nov 25, 2023
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Nov 25, 2023

I merged a bit too fast :-) It lacks at least a metadata version dump

@shinemoon
Copy link
Contributor Author

I merged a bit too fast :-) It lacks at least a metadata version dump

Thanks Alkarex, but there should be already v0.3..i.e. 1 initial version (0.1) + 2 tickets, so I would say it's expected version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] xExtension-ColorfulList: JavaScript error on pages that have no feed articles
4 participants