CodeQL fixes

FrendsPlatform · Feb 12, 2024 · 46aebb8 · 46aebb8
1 parent e97f631
commit 46aebb8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/...crosoftSQL.ExecuteProcedure/Frends.MicrosoftSQL.ExecuteProcedure.Tests/ScalarUnitTests.cs b/...crosoftSQL.ExecuteProcedure/Frends.MicrosoftSQL.ExecuteProcedure.Tests/ScalarUnitTests.cs
@@ -152,15 +152,8 @@ public async Task TestExecuteProcedure_Scalar()
             Parameters = null
         };
 
-        foreach (var level in transactionLevels)
+        foreach (var options in transactionLevels.Select(e => new Options { SqlTransactionIsolationLevel = e, CommandTimeoutSeconds = 2, ThrowErrorOnFailure = true}))
         {
-            var options = new Options()
-            {
-                SqlTransactionIsolationLevel = level,
-                CommandTimeoutSeconds = 2,
-                ThrowErrorOnFailure = true
-            };
-
             // Insert rows
             var insert = await MicrosoftSQL.ExecuteProcedure(inputInsert, options, default);
             Assert.IsTrue(insert.Success);

diff --git a/...ds.MicrosoftSQL.ExecuteProcedure/Frends.MicrosoftSQL.ExecuteProcedure/ExecuteProcedure.cs b/...ds.MicrosoftSQL.ExecuteProcedure/Frends.MicrosoftSQL.ExecuteProcedure/ExecuteProcedure.cs
@@ -82,7 +82,7 @@ private static async Task<Result> ExecuteHandler(Input input, Options options, S
         Result result;
         object dataObject;
         SqlDataReader dataReader = null;
-        var table = new DataTable();
+        using var table = new DataTable();
 
         try
         {