AzureBlobStorage tasks - update Azure.Identity #89
Conversation
- Updated Azure.Identity dependency to 1.12.0 in every task. - Fixed outdated environment variables in tests and workflows for ListBlobsInContainer and DeleteBlob. - Removed dependencies Azure.Storage.Common and Azure.Core in DownloadBlob, as has been done in the other BlobStorage tasks.
WalkthroughThe changes involve a comprehensive update to environment variable naming conventions across multiple GitHub Actions workflow files and corresponding project configurations in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Workflow
participant AzureBlobStorage
User->>Workflow: Trigger Event
Workflow->>AzureBlobStorage: Access Blob Storage
AzureBlobStorage-->>Workflow: Return Results
Workflow-->>User: Display Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
charlotta-frends
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range, codebase verification and nitpick comments (6)
Frends.AzureBlobStorage.ReadBlob/CHANGELOG.md (1)
3-5: Avoid repetition in changelog entries.The word "Updated" is repeated in the changelog entry. Consider rephrasing to improve clarity.
Apply this diff to refine the entry:
### Updated -- Updated Azure.Identity to version 1.12.0. +- Azure.Identity updated to version 1.12.0.Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.CreateContainer/CHANGELOG.md (1)
3-5: Avoid repetition in changelog entries.The word "Updated" is repeated in the changelog entry. Consider rephrasing to improve clarity.
Apply this diff to refine the entry:
### Updated -- Updated Azure.Identity to version 1.12.0. +- Azure.Identity updated to version 1.12.0.Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.3.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.DeleteContainer/CHANGELOG.md (1)
3-5: Avoid repetition in changelog entries.The word "Updated" is repeated in the changelog entry. Consider rephrasing to improve clarity.
Apply this diff to refine the entry:
### Updated -- Updated Azure.Identity to version 1.12.0. +- Azure.Identity updated to version 1.12.0.Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.ListBlobsInContainer/CHANGELOG.md (1)
4-5: Avoid repetition in changelog entries.The word "Updated" is repeated in the changelog entry. Consider rephrasing for clarity.
Apply this diff to improve the entry:
### Updated - Azure.Identity upgraded to version 1.12.0.Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ### C...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.UploadBlob/CHANGELOG.md (1)
4-4: Check for potential duplication in wording.There might be a repeated word in the changelog entry. Please review the wording for clarity.
Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ...angelog[2.1.0] - 2024-08-21
Updated
- Updated Azure.Identity to version 1.12.0.
##...
(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.DeleteBlob/CHANGELOG.md (1)
4-4: Check for potential duplication in wording.There might be a repeated word in the changelog entry. Please review the wording for clarity.
Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ...angelog[1.2.0] - 2024-08-21
Updated
- Updated Azure.Identity to version 1.12.0.
...
(ENGLISH_WORD_REPEAT_RULE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (22)
- .github/workflows/DeleteBlob_build_and_test_on_main.yml (1 hunks)
- .github/workflows/DeleteBlob_build_and_test_on_push.yml (1 hunks)
- .github/workflows/ListBlobsInContainer_build_and_test_on_main.yml (1 hunks)
- .github/workflows/ListBlobsInContainer_build_and_test_on_push.yml (1 hunks)
- Frends.AzureBlobStorage.CreateContainer/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.CreateContainer/Frends.AzureBlobStorage.CreateContainer/Frends.AzureBlobStorage.CreateContainer.csproj (2 hunks)
- Frends.AzureBlobStorage.DeleteBlob/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob.Tests/UnitTests.cs (1 hunks)
- Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob.csproj (2 hunks)
- Frends.AzureBlobStorage.DeleteContainer/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.DeleteContainer/Frends.AzureBlobStorage.DeleteContainer/Frends.AzureBlobStorage.DeleteContainer.csproj (2 hunks)
- Frends.AzureBlobStorage.DownloadBlob/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.DownloadBlob/Frends.AzureBlobStorage.DownloadBlob/Frends.AzureBlobStorage.DownloadBlob.csproj (2 hunks)
- Frends.AzureBlobStorage.ListBlobsInContainer/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/ConnectionStringUnitTests.cs (3 hunks)
- Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/OAuthUnitTests.cs (3 hunks)
- Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/SASUnitTests.cs (5 hunks)
- Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.csproj (2 hunks)
- Frends.AzureBlobStorage.ReadBlob/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.ReadBlob/Frends.AzureBlobStorage.ReadBlob/Frends.AzureBlobStorage.ReadBlob.csproj (2 hunks)
- Frends.AzureBlobStorage.UploadBlob/CHANGELOG.md (1 hunks)
- Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob.csproj (2 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/DeleteBlob_build_and_test_on_main.yml
- .github/workflows/DeleteBlob_build_and_test_on_push.yml
- .github/workflows/ListBlobsInContainer_build_and_test_on_main.yml
- Frends.AzureBlobStorage.ReadBlob/Frends.AzureBlobStorage.ReadBlob/Frends.AzureBlobStorage.ReadBlob.csproj
Additional context used
LanguageTool
Frends.AzureBlobStorage.ReadBlob/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.CreateContainer/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.3.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.DeleteContainer/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ## [...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.ListBlobsInContainer/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ... Changelog ## [1.2.0] - 2024-08-21 ### Updated - Updated Azure.Identity to version 1.12.0. ### C...(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.UploadBlob/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ...angelog[2.1.0] - 2024-08-21
Updated
- Updated Azure.Identity to version 1.12.0.
##...
(ENGLISH_WORD_REPEAT_RULE)
Frends.AzureBlobStorage.DeleteBlob/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word
Context: ...angelog[1.2.0] - 2024-08-21
Updated
- Updated Azure.Identity to version 1.12.0.
...
(ENGLISH_WORD_REPEAT_RULE)
Additional comments not posted (17)
Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob.csproj (1)
5-5: LGTM! Version and dependency updates are appropriate.The project version and Azure.Identity package have been updated correctly to reflect the latest changes.
Also applies to: 25-25
Frends.AzureBlobStorage.CreateContainer/Frends.AzureBlobStorage.CreateContainer/Frends.AzureBlobStorage.CreateContainer.csproj (1)
4-4: LGTM! Version and dependency updates are appropriate.The project version and Azure.Identity package have been updated correctly to reflect the latest changes.
Also applies to: 24-24
Frends.AzureBlobStorage.DeleteContainer/Frends.AzureBlobStorage.DeleteContainer/Frends.AzureBlobStorage.DeleteContainer.csproj (2)
5-5: Version update acknowledged.The project version has been updated from
1.1.1to1.2.0, indicating a new release. Ensure that this version aligns with the changes made and any new features or fixes introduced.
25-25: Azure.Identity package update acknowledged.The
Azure.Identitypackage version has been updated from1.10.4to1.12.0. Verify that this update is compatible with the rest of the codebase and any other dependencies.Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob.csproj (2)
5-5: Version update acknowledged.The project version has been updated from
2.0.1to2.1.0, suggesting a minor release. Ensure that this version aligns with the changes made and any new features or fixes introduced.
25-25: Azure.Identity package update acknowledged.The
Azure.Identitypackage version has been updated from1.10.4to1.12.0. Verify that this update is compatible with the rest of the codebase and any other dependencies.Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.csproj (2)
5-5: Version update acknowledged.The project version has been updated from
1.1.2to1.2.0, indicating a new release. Ensure that this version aligns with the changes made and any new features or fixes introduced.
25-25: Azure.Identity package update acknowledged.The
Azure.Identitypackage version has been updated from1.10.4to1.12.0. Verify that this update is compatible with the rest of the codebase and any other dependencies.Frends.AzureBlobStorage.DownloadBlob/Frends.AzureBlobStorage.DownloadBlob/Frends.AzureBlobStorage.DownloadBlob.csproj (2)
5-5: Version update acknowledged.The version number has been updated to 1.3.0, indicating a new release.
25-25: Dependency updates acknowledged.The
Azure.Identitypackage has been updated to version 1.12.0. The removal ofAzure.Storage.CommonandAzure.Coredependencies suggests a streamlining of the project's requirements..github/workflows/ListBlobsInContainer_build_and_test_on_push.yml (1)
16-21: Environment variable renaming approved.The renaming of environment variables and secrets aligns with the updated naming convention.
Also applies to: 25-30
Frends.AzureBlobStorage.DownloadBlob/CHANGELOG.md (1)
3-6: Changelog updates approved.The changelog entries accurately reflect the changes made in the release, including the package update and dependency removal.
Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/ConnectionStringUnitTests.cs (1)
15-15: Connection string update approved.The update to the connection string environment variable aligns with the new naming convention.
Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/OAuthUnitTests.cs (1)
15-20: Ensure environment variables are set correctly.The environment variable names have been updated to use the "Frends" prefix. Verify that these variables are correctly set in the test environment to avoid runtime errors.
Frends.AzureBlobStorage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/SASUnitTests.cs (2)
18-21: Ensure environment variables are set correctly.The environment variable names have been updated to use the "Frends" prefix. Verify that these variables are correctly set in the test environment to avoid runtime errors.
149-149: Ensure correct credentials are used for SAS token generation.The
StorageSharedKeyCredentialnow uses the_storageaccountvariable. Verify that the correct credentials are being used to generate the SAS token.Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob.Tests/UnitTests.cs (1)
15-19: Ensure environment variables are set correctly.The environment variable names have been updated to use the "Frends" prefix. Verify that these variables are correctly set in the test environment to avoid runtime errors.
...ge.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/OAuthUnitTests.cs
Show resolved
Hide resolved
...ge.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/OAuthUnitTests.cs
Show resolved
Hide resolved
...rage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/SASUnitTests.cs
Show resolved
Hide resolved
...rage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/SASUnitTests.cs
Show resolved
Hide resolved
...rage.ListBlobsInContainer/Frends.AzureBlobStorage.ListBlobsInContainer.Tests/SASUnitTests.cs
Show resolved
Hide resolved
Frends.AzureBlobStorage.DeleteBlob/Frends.AzureBlobStorage.DeleteBlob.Tests/UnitTests.cs
Show resolved
Hide resolved
#88
Also removed dependencies Azure.Storage.Common and Azure.Core for DownloadBlob, as has been done in the other BlobStorage tasks. And fixed the old environment variables for ListBlobsInContainer and DeleteBlob.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation