-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected]_py310: attempt to fix pyside runtime error with post i… #630
Conversation
cce7f5c
to
f5d1d86
Compare
f5d1d86
to
94046f9
Compare
this one has been a battle (to say the least), so from what i can tell forks of a repo can not use secrets stored in a upstream repo, thus generating a token classic or PAT that is stored in this repo ie. freecad/homebrew-freecad can not be used to say get a list of self-hosted runners accessible by the repo. github actions do provide a token ie. a GITHUB_TOKEN that is generated for each workflow run, and this token has permissive permissions to access certain aspects of the repo. though the token ie. the GITHUB_TOKEN can not be used to make authenticated API requests to the github api. thus making it difficult next to impossible (from what i can tell) to fork this repo create PR and then have the workflow run ie. test.yml to get a list of self-hosted runners, and apply / store a env var in the GITHUB_ENV for the workflow. the only work around i have managed to get going is to directly create a new branch in the upstream ie. freecad/homebrew-freecad of the same name, and this branch can access the token stored in the github secrets for the repo, and thus make the necessary api requests to status self-hosted runners stored in the repo. 😵💫 |
the current issue i'm running into using the self-hosted runner ie. ubuntu 22.04 is below, which i find odd because it appears to a logic error related the associated ruby file ...fun
|
i think the next logical step is open another PR but from my fork of this repo, and see if the self-hosted runner presents the same error message. my hunch makes me think that since this is a branch of the same repo that logic in the above mentioned ruby files can not handle this edge case of using test-bot with a repo and a branch of the same repo as opposed to using a repo fork ie. ipatch/homebrew-freecad instead of freecad/homebrew-freecad for the branch PR. 🧐 |
it appears my assumption stated in the above comment ie.
using the traditional test-bot workflow the run on the self-hosted runner will reach the below step,
thus the default logic in homebrew has not been setup to handle a use case where a branch of the same repo is used to create a PR and update the main / master branch the changes in the PR. |
the original intent behind this PR is to hopefully resolve the issue with the proxy pyside module referencing the main PySide2 module. as the post_install step was creating absolute symlinks, and for reasons I do not completely understand that both the and in the process i setup a self-hosted runner on an additional macbook running ubuntu 22.04. this runner was setup to hopefully troubleshoot the ongoing issue with CI build failures with the github ubuntu runners related to the missing above mentioned undocumented environment variable
and in the process of troubleshooting https://gist.github.com/ipatch/8517a5914d56c45b0ebc4dd4df5160c4 |
it looks like test-bot may still attempt to clean regardless if env var is set. |
…nstall step
output from running above command should output something similiar to the below
Not all PRs require passing these checks ie. adding
[no ci]
in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)For more information about this template file learn more