Improve asynchronous failure handling #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon #20 by adding better handling of asynchronous failures. As an example, we use asynchronous features loading to query our database, which can error. Currently we don't have a way to catch and handle those failures.
This PR updates the
callback
-function forconfig
andreload
, such that it accepts two arguments:err
anddata
. This means that it conforms to the common error-first callback style, i.e. taking a(err, value) => ...
function. Further, it means that you can easily promisify the two functions as follows:Note that this is a breaking change 😞