fix: lint goconst (#37)

FrangipaneTeam · Oct 23, 2023 · 958c743 · 958c743
1 parent 16b0412
commit 958c743
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/base.go b/base.go
@@ -6,4 +6,8 @@ import (
 	_ "github.com/iancoleman/strcase"
 )
 
+const (
+	errorTest = "An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"
+)
+
 //go:generate go run template.go
diff --git a/list_value_test.go b/list_value_test.go
@@ -162,7 +162,7 @@ func TestNewListValueFrom(t *testing.T) {
 				diag.NewAttributeErrorDiagnostic(
 					path.Empty(),
 					"List Type Validation Error",
-					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+					errorTest+
 						"expected List value, received tftypes.Value with value: tftypes.String<\"oops\">",
 				),
 			},
@@ -774,7 +774,7 @@ func TestListTypeValidate(t *testing.T) {
 				diag.NewAttributeErrorDiagnostic(
 					path.Root("test"),
 					"List Type Validation Error",
-					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+					errorTest+
 						"expected List value, received tftypes.Value with value: tftypes.Set[tftypes.String]<tftypes.String<\"testvalue\">>",
 				),
 			},

diff --git a/map_value_test.go b/map_value_test.go
@@ -160,7 +160,7 @@ func TestNewMapValueFrom(t *testing.T) {
 				diag.NewAttributeErrorDiagnostic(
 					path.Empty(),
 					"Map Type Validation Error",
-					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+					errorTest+
 						"expected Map value, received tftypes.Value with value: tftypes.String<\"oops\">",
 				),
 			},
@@ -853,7 +853,7 @@ func TestMapTypeValidate(t *testing.T) {
 				diag.NewAttributeErrorDiagnostic(
 					path.Root("test"),
 					"Map Type Validation Error",
-					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+					errorTest+
 						"expected Map value, received tftypes.Value with value: tftypes.List[tftypes.String]<tftypes.String<\"testvalue\">>",
 				),
 			},

diff --git a/set_value_test.go b/set_value_test.go
@@ -274,7 +274,7 @@ package supertypes
 // 				diag.NewAttributeErrorDiagnostic(
 // 					path.Root("test"),
 // 					"Set Type Validation Error",
-// 					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+// 					errorTest +
 // 						"expected Set value, received tftypes.Value with value: tftypes.List[tftypes.String]<tftypes.String<\"testvalue\">>",
 // 				),
 // 			},
@@ -442,7 +442,7 @@ package supertypes
 // 				diag.NewAttributeErrorDiagnostic(
 // 					path.Empty(),
 // 					"Set Type Validation Error",
-// 					"An unexpected error was encountered trying to validate an attribute value. This is always an error in the provider. Please report the following to the provider developer:\n\n"+
+// 					errorTest +
 // 						"expected Set value, received tftypes.Value with value: tftypes.String<\"oops\">",
 // 				),
 // 			},