Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run ci for pull requests #86

Merged

Conversation

tobil4sk
Copy link
Contributor

@tobil4sk tobil4sk commented Aug 2, 2024

This way we can see if a PR will break the tests

This way we can see if a PR will break the tests
@FourierTransformer
Copy link
Owner

I'm going to look into some various options (at some point) to allow this for only approved people (or "approved PRs" maybe).

@tobil4sk
Copy link
Contributor Author

tobil4sk commented Aug 2, 2024

I think by default it won't run for new contributors until a maintainer manually approves it, but maybe best to double check this.

@FourierTransformer
Copy link
Owner

Yeah, the repo settings will now require approval for first time contributors. This should be good to go!

@FourierTransformer FourierTransformer merged commit 5d0bfde into FourierTransformer:master Aug 4, 2024
18 checks passed
@tobil4sk tobil4sk deleted the ci-pull-request branch August 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants