Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump simdjson to version 3.2.3 #59

Closed
wants to merge 1 commit into from
Closed

bump simdjson to version 3.2.3 #59

wants to merge 1 commit into from

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Jul 7, 2023

This pull request updates simdjson to 3.2.3, the most recent version.

Closes #61.
Closes #60.
Closes #57.
Closes #56.

@FourierTransformer: You possibly want to merge #58 first to make sure that lua-simdjson still builds properly on CI.

@striezel striezel changed the title bump simdjson to version 3.2.1 bump simdjson to version 3.2.3 Sep 26, 2023
Closes #61.
Closes #60.
Closes #57.
Closes #56.
@striezel
Copy link
Contributor Author

@FourierTransformer: I've just rebased this pull request on top of the current master branch and updated simdjson from version 3.2.1 to version 3.2.3.

@FourierTransformer
Copy link
Owner

I've actually been playing around with this lately, and it seems like the json pointer code can cause segfaults. I haven't figured out if it's related to the new version yet, but overall it doesn't seem great.

@striezel
Copy link
Contributor Author

striezel commented Oct 3, 2023

I've actually been playing around with this lately, and it seems like the json pointer code can cause segfaults.

Can you provide more details on that? A small, reproducible example would also be helpful.

@FourierTransformer
Copy link
Owner

I noticed it when I first started updating some of the unit tests to 3.3.0. I have a draft pr/branch out here: #63 Looks like it's failing in GHA as well with the new tests. The optimization level doesn't seem to affect it. I ran the unit tests and it seemed to work on the old version of the code just fine. I'm going to assume some of the internals changed in the past 3 major versions... heh...

rough copy from the interpreter:

simdjson = require("simdjson")
function loadFile(textFile)
    local file = io.open(textFile, "r")
    if not file then error("File not found at " .. textFile) end
    local allLines = file:read("*all")
    file:close()
    return allLines
end
demo = loadFile("jsonexamples/small/demo.json")
djson = simdjson.open(demo)
djson:atPointer("/Image/Width")
simdjson.openFile("jsonexamples/small/demo.json")
Segmentation fault (core dumped)

@FourierTransformer
Copy link
Owner

closing in favor of #83

@striezel
Copy link
Contributor Author

So the segfaults you mentioned are fixed in #83, I assume? That's good news. :)

@striezel striezel deleted the simdjson-update branch July 31, 2024 20:31
@FourierTransformer
Copy link
Owner

Yup! The new[er] simdjson ondemand parser, you need to keep the parser, document, and string in scope and it wasn't quite doing that >.<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3.2.3 Version 3.2.2 Version 3.2.1 Version 3.2.0
2 participants