Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1D advection-diffusion #55

Merged
merged 38 commits into from
Jun 29, 2022
Merged

Add 1D advection-diffusion #55

merged 38 commits into from
Jun 29, 2022

Commits on Jun 9, 2022

  1. Add 1D advection-diffusion of passive tracer 

    Have added the functions to do this but the way the multiple dispatch is used is not so good. Need to write some tests to make sure that everything is working correctly then check with Navid if there is a better to way to set this up. I think doing it this way generalises very easy to the 3D domain.
    @jbisits
    jbisits committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    082752c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Add tests for one dimensional problem 

    Add the example to the documents as well.
    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    acc6100 View commit details
    Browse the repository at this point in the history

  2. grid.x -> gr.x

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    787ad32 View commit details
    Browse the repository at this point in the history

  3. Missed a comma

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    15e73c9 View commit details
    Browse the repository at this point in the history

  4. Correct file name

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    366f85e View commit details
    Browse the repository at this point in the history

  5. and in the literated part of the script

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    31ae371 View commit details
    Browse the repository at this point in the history

  6. Fix file name (again) and add Plots to example

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    28cef9c View commit details
    Browse the repository at this point in the history

  7. See if @CUDA.allowscalar is the fix

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    aca90c5 View commit details
    Browse the repository at this point in the history

  8. Was not correct, removed

    @jbisits
    jbisits committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    73f43dc View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Add ArrayType(dev) to create a CuArray

    @jbisits
    jbisits committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    1e01031 View commit details
    Browse the repository at this point in the history

  2. Try making c0 CuArray

    @jbisits
    jbisits committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    f58d8ce View commit details
    Browse the repository at this point in the history

  3. Trying another method

    @jbisits
    jbisits committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    f7b67f4 View commit details
    Browse the repository at this point in the history

  4. Maybe this way? 

    Not sure if this is the problem but worth trying to see if the issue is `c0` not being of type `CuArray` in the GPU run.
    @jbisits
    jbisits committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    293f208 View commit details
    Browse the repository at this point in the history

  5. Did not seem to be the issue so changed back

    @jbisits
    jbisits committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ff4b879 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. gr.x -> ArrayType(dev)(gr.x) 

    Hopefully this fixes the test that fail on the `GPU`.
    @jbisits
    jbisits committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2e42d89 View commit details
    Browse the repository at this point in the history

  2. Maybe this will do it

    @jbisits
    jbisits committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    5315112 View commit details
    Browse the repository at this point in the history

  3. Update test_traceradvectiondiffusion.jl

    @jbisits
    jbisits committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    6277201 View commit details
    Browse the repository at this point in the history

  4. I think this should fix it

    @jbisits
    jbisits committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    fa49dda View commit details
    Browse the repository at this point in the history

  5. pass dev to constructors

    @jbisits
    jbisits committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a8c803d View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Problem(dev; parameters) -> `Problem(dev, advecting_flow; parameters) 

    This is a breaking change. Not sure if it is the best way to setup the methods but it is an idea and better than what I had initially.
    @jbisits
    jbisits committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    51f9361 View commit details
    Browse the repository at this point in the history

  2. Remove u and v from parameters in celluarflow.jl

    @jbisits
    jbisits committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    e05924e View commit details
    Browse the repository at this point in the history

  3. update compat requirements

    @navidcy
    navidcy committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    6a54b9e View commit details
    Browse the repository at this point in the history

  4. use x = gridpoints(::OneDGrid)

    @jbisits
    jbisits committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0a0b859 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Docstring update

    @jbisits
    jbisits committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    6655399 View commit details
    Browse the repository at this point in the history

  2. Another Docstring

    @jbisits
    jbisits committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0ffd42b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Change to using constructors for the advecting_flow 

    By creating the `abstract type AdvectingFlow` we can use types `OneDAdvectingFlow` and `TwoDAdvectingFlow` for the methods in `Problem`.
    @jbisits
    jbisits committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6578acc View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. minor fiddling

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    731d709 View commit details
    Browse the repository at this point in the history

  2. bump minor release

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    300ec2e View commit details
    Browse the repository at this point in the history

  3. simpler kwargs

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d2d1537 View commit details
    Browse the repository at this point in the history

  4. Change default steadyflow to true

    @jbisits
    jbisits committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    9b20ebd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'add-1Dadvection-diffusion' of https://github.com/jbisit… 

    …s/PassiveTracerFlows.jl into add-1Dadvection-diffusion
    @jbisits
    jbisits committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d61c700 View commit details
    Browse the repository at this point in the history

  6. Change tests to match new default value for steadyflow

    @jbisits
    jbisits committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    7b2622b View commit details
    Browse the repository at this point in the history

  7. some minor changes

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d08fa5c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'add-1Dadvection-diffusion' of github.com:jbisits/Passiv… 

    …eTracerFlows.jl into add-1Dadvection-diffusion
    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fc3ef72 View commit details
    Browse the repository at this point in the history

  9. homogenize some docstrings

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0f2b4c3 View commit details
    Browse the repository at this point in the history

  10. Update examples/cellularflow.jl 

    Fix typo

Co-authored-by: Navid C. Constantinou <[email protected]>
    @jbisits @navidcy
    jbisits and navidcy authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    af94ba2 View commit details
    Browse the repository at this point in the history

  11. update zenodo citation

    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bacae4d View commit details
    Browse the repository at this point in the history

  12. Merge branch 'add-1Dadvection-diffusion' of github.com:jbisits/Passiv… 

    …eTracerFlows.jl into add-1Dadvection-diffusion
    @navidcy
    navidcy committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2488c76 View commit details
    Browse the repository at this point in the history