Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RK4 and AB3 timesteppers for sol<:AbstractArray #106

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Jan 19, 2019

  • RK4substeps! function for sol::AbstractArray was missing args t and dt
  • overloads AB3 timestepper so that it works with sol::AbstractArray

- RK4substeps! function for sol::AbstractArray was missing args t and dt
- overloads AB3 timestepper so that it works with sol::AbstractArray
@navidcy navidcy requested a review from glwagner January 19, 2019 17:06
@navidcy
Copy link
Member Author

navidcy commented Jan 19, 2019

After this is merged I'll implement what issue #100 discusses (i.e., remove Filtered versions of timesteppers).

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #106 into master will decrease coverage by 0.95%.
The diff coverage is 61.11%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #106      +/-   ##
========================================
- Coverage   72.95%    72%   -0.96%     
========================================
  Files           8      8              
  Lines         488    500      +12     
========================================
+ Hits          356    360       +4     
- Misses        132    140       +8
Impacted Files Coverage Δ
src/timesteppers.jl 73.36% <61.11%> (-2.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5817e...7236d3d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 71.888% when pulling 7236d3d on FixAbstractSolTimeStepping into 9e5817e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 71.888% when pulling 7236d3d on FixAbstractSolTimeStepping into 9e5817e on master.

@navidcy navidcy merged commit f7a87d4 into master Jan 27, 2019
@navidcy navidcy deleted the FixAbstractSolTimeStepping branch June 30, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants