Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison keys to plan string for in-union #2900

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alecgrieser
Copy link
Contributor

The comparisonKeyFunction is currently not included in the plan representation of InUnion plans. This can make it hard to inspect bugs that could be a result of an in-union improperly merging results from different legs of a union. This does make the plan representation a little more verbose, though hopefully manageably so. It should be less intrusive, for example, than a regular union, which puts the comparison key between each leg of the union (unless the comparison is by primary key).

@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 6c5b982
  • Duration 0:51:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants