Query plan with IN as Union fails to display plan graph in CloudKit console #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a5a44b.
Result of fdb-record-layer-pr on Linux CentOS 7
|
normen662
requested changes
Apr 16, 2024
| public String identifier(@Nonnull String bindingName) { | ||
| Verify.verify(bindingName.startsWith(value)); | ||
| return bindingName.substring(value.length()); | ||
| public String identifier(@Nonnull final String bindingName) { |
There was a problem hiding this comment.
So we want the old identifier method to also stay there since we want to allow callers to explicitly state the want to resolve an alias to an e.g. CORRELATION. The old identifier() should be renamed to let's say typedIdentifier() and it should stay an instance method. This new identifier() method should become static. All callers should call typedIdentifier(), except the one you have where we don't know what it is.
pengpeng-lu
commented
Apr 16, 2024
| @@ -205,7 +205,7 @@ public Set<CorrelationIdentifier> getCorrelatedTo() { | |||
|
|
|||
| final var inAliases = getInSources() | |||
| .stream() | |||
| .map(inSource -> CorrelationIdentifier.of(Bindings.Internal.CORRELATION.identifier(inSource.getBindingName()))) | |||
| .map(inSource -> CorrelationIdentifier.of(Bindings.Internal.identifier(inSource.getBindingName()))) | |||
There was a problem hiding this comment.
only this one is using the new identifier
Result of fdb-record-layer-pr on Linux CentOS 7
|
Result of fdb-record-layer-pr on Linux CentOS 7
|
pengpeng-lu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.