Skip to content

Commit

Permalink
Output fullscreen support because Safari
Browse files Browse the repository at this point in the history
It's still showing the fullscreen button and pressing the button is still trying to do something - despite the site now having updated and not throwing any errors about the feature checking code now. My theory is that Safari iOS claims to support requestFullscreen even though it doesn't actually.. would hardly be the first time Apple have done this (indexedDB, web Push..). Especially as they tried to implement fullscreen in iOS 17.6 but gave up, and are now trying to in iOS 18 beta (although off by default and doesn't seem to do anything when on).
  • Loading branch information
FormularSumo committed Sep 11, 2024
1 parent 87431ba commit 2cf1210
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@
if (document.body.requestFullscreen == 'undefined' && document.body.webkitRequestFullscreen == 'undefined' && document.body.mozRequestFullScreen == 'undefined') {
document.getElementById("fullscreen-toggle").remove(); //Remove fullscreenbutton on iOS where it's not supported..
}
console.log(document.body.requestFullscreen);
console.log(document.body.webkitRequestFullscreen);
console.log(document.body.mozRequestFullScreen);
</script>
</body>
</html>
2 changes: 1 addition & 1 deletion sw.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const CACHE_NAME = `0.12.0.2`; // stable.pre-release.minor.web
const CACHE_NAME = `0.12.0.3 `; // stable.pre-release.minor.web

// Use the install event to pre-cache all initial resources.
self.addEventListener('install', event => {
Expand Down

3 comments on commit 2cf1210

@FormularSumo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG_0470
Seems my theory is incorrect. But given it is being correctly reported as undefined, why is the sandbox button not being removed?

@FormularSumo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG_0471
Pressing the fullscreen button is trying to do things for some reason

@FormularSumo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8

Please sign in to comment.