create-spectacle CLI: Fix generated spectacle version, add custom types for MD build.
#1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carloskelly13
requested review from
scottrippey,
keithluchtel and
carbonrobot
keithluchtel
approved these changes
Dec 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.tsxtemplate file. This will allow us to expand the content to support new outputs down the road. Also fixes the formatting so it's nicely indented.package.jsonversion ofspectacleto not be a*which trips up pnpm and uses the version from the core library'spackage.jsoncustom.d.tsfile in the Markdown output so the import of the.mdfile does not throw an unknown type error.Screenshot of the cleaned up, correctly indented
index.tsx:How to test
packages/create-spectaclepnpm devmdand the two React flavorsnpm i && npm run startin each output and verify they load up