Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tabs for payload and response #150

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Implement tabs for payload and response #150

merged 3 commits into from
Oct 24, 2023

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Oct 24, 2023

Implement tabs for payload and response

Before

image

After

image

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 1056e41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@envyjs/webui Patch
@envyjs/apollo Patch
@envyjs/core Patch
@envyjs/nextjs Patch
@envyjs/node Patch
@envyjs/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carbonrobot carbonrobot changed the title ui/tabs Implement tabs for payload and response Oct 24, 2023
<div data-test-id="summary" className="p-default mb-4">
<div className="flex flex-row">
<div className="flex-0 mr-2 md:mr-4">
<img src={getIconUri(trace)} alt="" className="w-6 h-6 md:w-12 md:h-12" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth using maybe the trace data here for our alt tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could place the system name there, but it will require changing a few other things to do so. I'll make a ticket for it in the backlog.

{responseComplete && statusCode && (
<div data-test-id="response-status" className="absolute bottom-0 right-0 p-default flex items-center gap-2">
<span className={statusCodeStyle(statusCode)}></span>
{`${statusCode > -1 ? statusCode : ''} ${statusMessage}`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is false, would we end up printing an extra start space here? (The character before ${statusMessage} inside the TTL)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace settings for HTML will remove extra spaces automatically

image

Copy link

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two questions.

@carbonrobot carbonrobot merged commit 804172c into main Oct 24, 2023
4 checks passed
@carbonrobot carbonrobot deleted the ui/tabs branch October 24, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants