-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tabs for payload and response #150
Conversation
🦋 Changeset detectedLatest commit: 1056e41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<div data-test-id="summary" className="p-default mb-4"> | ||
<div className="flex flex-row"> | ||
<div className="flex-0 mr-2 md:mr-4"> | ||
<img src={getIconUri(trace)} alt="" className="w-6 h-6 md:w-12 md:h-12" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth using maybe the trace
data here for our alt tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could place the system name there, but it will require changing a few other things to do so. I'll make a ticket for it in the backlog.
{responseComplete && statusCode && ( | ||
<div data-test-id="response-status" className="absolute bottom-0 right-0 p-default flex items-center gap-2"> | ||
<span className={statusCodeStyle(statusCode)}></span> | ||
{`${statusCode > -1 ? statusCode : ''} ${statusMessage}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this is false, would we end up printing an extra start space here? (The character before ${statusMessage}
inside the TTL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two questions.
Implement tabs for payload and response
Before
After