SDKS 3618- New React Native Project #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyanthanperiyasamy
requested review from
george-bafaloukas-forgerock,
rodrigoareis and
spetrov
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
3 times, most recently
from
6dfe5c8 to
ef9aa20
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
2 times, most recently
from
483c928 to
f4d2148
Compare
jeyanthanperiyasamy
changed the title
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
from
f4d2148 to
6a9a95e
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
3 times, most recently
from
839f242 to
bd18f80
Compare
witrisna
reviewed
Dec 17, 2024
reactnative/reactnative-todo/android/app/src/debug/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
...tnative/reactnative-todo/android/app/src/main/java/com/reactnativetodo/FRAuthSampleBridge.kt
Show resolved
Hide resolved
reactnative/reactnative-todo/android/app/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
3 times, most recently
from
45a6467 to
5f7fecb
Compare
rodrigoareis
requested changes
Dec 18, 2024
...tnative/reactnative-todo/android/app/src/main/java/com/reactnativetodo/FRAuthSampleBridge.kt
Show resolved
Hide resolved
reactnative/reactnative-todo/android/app/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
reactnative/reactnative-todo/android/app/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
reactnative/reactnative-todo/android/app/src/main/res/values/strings.xml
Show resolved
Hide resolved
reactnative/reactnative-todo/src/components/utilities/loading.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@jeyanthanperiyasamy ping me to discuss the comments when free. We will need on the back of that to create an update for the RN Tutorial for docs for Chris as well
reactnative/reactnative-todo/android/app/src/main/java/com/reactnativetodo/MainApplication.kt
Outdated
Show resolved
Hide resolved
reactnative/reactnative-todo/ios/reactnativetodo/FRAuthConfig.plist
Outdated
Show resolved
Hide resolved
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
2 times, most recently
from
04a7dba to
8da9886
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
11 times, most recently
from
c2d1003 to
a340038
Compare
|
Addressed most comments. please verify @rodrigoareis @george-bafaloukas-forgerock |
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
from
a340038 to
2560259
Compare
reactnative/reactnative-todo/.env.js
Outdated
| * Avoid trailing slashes in the URL string values below | ||
| */ | ||
| const API_PORT = 9443; | ||
| const API_BASE_URL = 'http://10.0.2.2'; // for iOS - http://localhost |
There was a problem hiding this comment.
Do we need this ip address and port here? Can we replace with placeholder?
There was a problem hiding this comment.
fixed as a placeholder.
| */ | ||
| data class Configuration( | ||
| /** The main authentication journey name. */ | ||
| val mainAuthenticationJourney: String = "jey-webAuthn", |
There was a problem hiding this comment.
Can we replace this config with placeholder? We should expose details of our environments publicly
There was a problem hiding this comment.
I agree replace all values with [Placeholders]
There was a problem hiding this comment.
ha i accidentally committed that ..good catch . Fixed now
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
3 times, most recently
from
db831f2 to
d099973
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-3618-New
branch
from
d099973 to
4470def
Compare
george-bafaloukas-forgerock
approved these changes
Dec 19, 2024
rodrigoareis
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.