SDKS-2782 cookiename/AM URL/Realm are mandatory field #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyanthanperiyasamy
force-pushed
the
SDKS-2782
branch
from
e06a326 to
89bd2cc
Compare
jeyanthanperiyasamy
changed the title
jeyanthanperiyasamy
force-pushed
the
SDKS-2782
branch
from
89bd2cc to
5eb711d
Compare
witrisna
reviewed
Nov 28, 2023
| url = sharedPreferences.getString(ConfigHelper.url, null) ?: "" | ||
| realm = sharedPreferences.getString(ConfigHelper.realm, null) ?: "" | ||
| cookieName = sharedPreferences.getString(ConfigHelper.cookieName, null) ?: "" | ||
| url = sharedPreferences.getString(ConfigHelper.url, null) ?: context.getString(R.string.forgerock_url) |
There was a problem hiding this comment.
Can we use the defValue sharedPreferences.getString(value, defValue) for the null case.
sharePreferences.getString(ConfigHelper.url, context.getString(R.string.forgerock_url)
There was a problem hiding this comment.
no change required. already discussed
witrisna
previously approved these changes
Nov 28, 2023
forgerock-auth/src/test/java/org/forgerock/android/auth/ConfigHelperTest.kt
Show resolved
Hide resolved
| @@ -47,6 +47,8 @@ public static synchronized void start(Context context, @Nullable FROptions optio | |||
| if(!started || !FROptions.equals(cachedOptions, options)) { | |||
| started = true; | |||
| FROptions currentOptions = ConfigHelper.load(context, options); | |||
| //Validate (AM URL, Realm, CookieName) is not Empty. If its empty will throw IllegalArgumentException. | |||
| currentOptions.validateConfig(); | |||
There was a problem hiding this comment.
Are we throwing the new exception here?
There was a problem hiding this comment.
yes , we are throwing a new exception, its intentional when the user supplies empty url, realm, cookiename . we dont usually declare the Runtime exception
spetrov
previously approved these changes
Nov 29, 2023
jeyanthanperiyasamy
dismissed stale reviews from spetrov and witrisna
via
172aee8
jeyanthanperiyasamy
force-pushed
the
SDKS-2782
branch
from
5eb711d to
172aee8
Compare
…les for url,realm,cookiename
jeyanthanperiyasamy
force-pushed
the
SDKS-2782
branch
from
172aee8 to
2460b0a
Compare
rodrigoareis
previously approved these changes
Nov 29, 2023
spetrov
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Please link jira ticket here
Description
1.The idea is to keep by default the cookiename and realm has value if the user didnt add this
cookiename = iplanetdirectorypro
realm = root