Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-2631 Android App Integrity Implementation #338

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

witrisna
Copy link
Contributor

JIRA Ticket

SDKS-2631

Description

SDKS-2631 Android App Integrity Implementation

.token())
}

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for future implementation ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is new from Google, would like to get it ready. I have high-level tested it, and it works as expected, but not ready to make it official at this moment.

@jeyanthanperiyasamy
Copy link
Contributor

jeyanthanperiyasamy commented Oct 23, 2023

looks good , try the memory profiler once to check the memory leaks in feature before merge this.

@@ -79,4 +77,7 @@ public String getType(Class<? extends Callback> callback) throws InstantiationEx
return callback.newInstance().getType();
}

public Map<String, Class<? extends Callback>> getCallbacks() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc updated.

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation looks good. Minor comments regarding javadoc

rodrigoareis
rodrigoareis previously approved these changes Oct 24, 2023
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻

@spetrov spetrov merged commit 88c81a3 into develop Nov 30, 2023
7 of 9 checks passed
@spetrov spetrov deleted the SDKS-2631 branch November 30, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants