-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKS-2631 Android App Integrity Implementation #338
Conversation
.token()) | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for future implementation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is new from Google, would like to get it ready. I have high-level tested it, and it works as expected, but not ready to make it official at this moment.
looks good , try the memory profiler once to check the memory leaks in feature before merge this. |
@@ -79,4 +77,7 @@ public String getType(Class<? extends Callback> callback) throws InstantiationEx | |||
return callback.newInstance().getType(); | |||
} | |||
|
|||
public Map<String, Class<? extends Callback>> getCallbacks() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadoc updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall implementation looks good. Minor comments regarding javadoc
c7ecdfc
to
61968d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
644e40c
to
6369fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍🏻
JIRA Ticket
SDKS-2631
Description
SDKS-2631 Android App Integrity Implementation