Dont charge world startup #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Paper API, we can clearly see that the creation of the world should not be put at the start of the server. In addition to that, it breaks the World Generators which load just after the plugin.
On my Skyblock plugin where I use the same methods, it works great, especially if I want it to work on Paper too. |
HSGamer
requested changes
Oct 22, 2024
There was a problem hiding this comment.
You missed the case when you create a brand new world.
We would need to call prepareLevels and the WorldLoadEvent ourselves. Otherwise, it would hang and cause server crash. The original goal is to let Folia call them on its own so that we can be sure everything works correctly.
Simply changing the load order is not enough.
HSGamer
reviewed
Oct 22, 2024
HSGamer
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Paper API, we can clearly see that the creation of the world should not be put at the start of the server. In addition to that, it breaks the World Generators which load just after the plugin.