Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return os name "win64" on Win x64 #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return os name "win64" on Win x64 #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/fah/client/win/WinOSImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,13 @@ void WinOSImpl::init() {
}


const char *WinOSImpl::getName() const {return "win32";}
const char *WinOSImpl::getName() const {
#ifdef _WIN64
return "win64";
#else
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

win32 isn't the only other option; this ignores 16 and ARM. It'd probably be simpler to just return win64 instead, since it's only compiled for 64bit computers.

return "win32";
#endif
}


const char *WinOSImpl::getCPU() const {
Expand Down