feat: add Java API for setting insertMode #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlopezFC
requested changes
Oct 14, 2021
| @@ -54,7 +55,7 @@ class ConsoleAddon extends TerminalAddon<IConsoleMixin> { | |||
| this.cursorBackward({params:[1]}); | |||
| return true; | |||
| } else if (buffer.lines.get(buffer.y+buffer.ybase).isWrapped) { | |||
| this.cursorPrecedingLine({params:[1]}); | |||
| this.cursorPrecedingLine({params:[1]}); | |||
There was a problem hiding this comment.
Can we discard this unneeded change?
| @@ -185,13 +181,27 @@ type Constructor<T = {}> = new (...args: any[]) => T; | |||
| export function XTermConsoleMixin<TBase extends Constructor<TerminalMixin>>(Base: TBase) { | |||
| return class XTermConsoleMixin extends Base implements IConsoleMixin { | |||
| escapeEnabled: Boolean; | |||
|
|
|||
javier-godoy
force-pushed
the
feature/17
branch
from
1dbd4ed to
2556742
Compare
javier-godoy
force-pushed
the
feature/17
branch
from
2556742 to
bf79502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of hardcoded DECSCUSR sequences (#19) is not correct, but that's a different issue.