fix: compute heightByRows while loading #123
Conversation
WalkthroughThe pull request introduces changes to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/resources/META-INF/frontend/fcGridHelper/connector.js (1)
Line range hint
80-103: Consider adding error handling for edge cases.While the computation logic is solid, consider adding checks for:
- Negative row numbers
- Missing table elements (thead/tfoot)
- Invalid offsetHeight values
computeHeightByRows : function(n) { + if (n < 0) { + throw new Error('Number of rows must be non-negative'); + } var height = 0; var rows = grid.shadowRoot.querySelectorAll("tbody tr"); if (rows.length>0) { for(var i=0;i<n && i<rows.length;i++) { height += rows[i].offsetHeight; } if (rows.length<n) { height *= n/rows.length; } } - height += grid.shadowRoot.querySelector("thead").offsetHeight; - height += grid.shadowRoot.querySelector("tfoot").offsetHeight; + const thead = grid.shadowRoot.querySelector("thead"); + const tfoot = grid.shadowRoot.querySelector("tfoot"); + height += thead ? thead.offsetHeight : 0; + height += tfoot ? tfoot.offsetHeight : 0;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom.xml(1 hunks)src/main/resources/META-INF/frontend/fcGridHelper/connector.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-vaadin24
🔇 Additional comments (3)
src/main/resources/META-INF/frontend/fcGridHelper/connector.js (2)
76-78: LGTM! Good extraction of height update logic.Clean separation of concerns by moving the height computation and CSS property update into a dedicated method.
60-74: LGTM! Good improvements to height calculation during loading states.The changes properly handle grid loading states and resize events. The cleanup of previous observers/listeners prevents memory leaks.
Let's verify the loading state behavior:
✅ Verification successful
✅ Loading state handling verified - no conflicts found
The loading-changed event handler is properly scoped and is the only one in the codebase, ensuring clean and predictable behavior during grid loading states.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if there are any other loading state handlers that might conflict rg -A 3 'loading-changed' --type jsLength of output: 891
pom.xml (1)
566-571: LGTM! Verify compatibility with Vaadin 24.The commons-demo dependency upgrade looks good, properly scoped for testing.
Let's verify version compatibility:
Close #117
Summary by CodeRabbit
commons-demoto version 4.2.0 in the v24 profile