XOR-85 [Feat] Toggle to show/hide read notifications with defaulted to only show unread #41
Conversation
removed extra space
tonytlwu
changed the title
css/build.css
Outdated
| padding-left: 10px; | ||
| } | ||
|
|
||
| [data-notification-inbox-1-0-0-id] .unread-label { |
There was a problem hiding this comment.
See section 10.2 in https://docs.google.com/document/d/1XPlQHPbqp3rGGTekcC05bKtwKDDjrU2RMJ4VIHLXp64/edit#
| [data-notification-inbox-1-0-0-id] .unread-label { | |
| [data-notification-inbox-1-0-0-id] .label-unread { |
There was a problem hiding this comment.
Did the changes suggested by tony. Also gone through the docs
css/build.css
Outdated
| display: block; | ||
| } | ||
|
|
||
| [data-notification-inbox-1-0-0-id] .show-all-label { |
There was a problem hiding this comment.
| [data-notification-inbox-1-0-0-id] .show-all-label { | |
| [data-notification-inbox-1-0-0-id] .label-show-all { |
There was a problem hiding this comment.
Did the changes suggested by tony. Also gone through the docs
js/libs.js
Outdated
| @@ -75,6 +75,8 @@ Fliplet.Registry.set('notification-inbox:1.0:core', function(element, data) { | |||
| $notifications.after($loadMore); | |||
| } | |||
|
|
|||
| $('.notification-read').hide(); | |||
There was a problem hiding this comment.
This line tells me that if when a notification is rendered, after it's rendered, always hide the notifications that are read. Shouldn't it only do that if the toggle says "Only show unread"? See the following acceptance criteria.
If toggle is active to only show unread => Notification list is refreshed after a notifications goes from unread to read (Read notification no longer displayed)
There was a problem hiding this comment.
it's my mistake. I will take care these thing next time. Did the changes suggested by u.
thanks
Product areas affected
fliplet-widget-notification-inbox
What does this PR do?
Toggle to show/hide read notifications, defaulted to only show unread
JIRA ticket
XOR-85
Result
XOR-85-R1.mp4
Checklist
-None
Testing instructions
-None
Deployment instructions
-None
Author concerns
-None