Fix/DEV-228 #696
Merged
Fix/DEV-228 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust custom button to be in line with form fields * ID-4527 [FIX] Adjust custom button to be in line with form fields
…dion of Add fields overlay after switching between settings tabs (#682)
…or on the screen if it is marked as required.
dwfliplet
reviewed
Nov 6, 2024
js/components/map.js
Outdated
| var rules = { | ||
| value: {} | ||
| }; | ||
|
|
||
| if (this.required && !this.readonly) { | ||
| rules.value.required = function() { | ||
| return $vm.value.address; | ||
| return this.value && this.value.address ? true : false; |
There was a problem hiding this comment.
Suggested change
| return this.value && this.value.address ? true : false; | |
| return !!(this.value?.address); |
There was a problem hiding this comment.
@dwfliplet I got ESLint error for ?
There was a problem hiding this comment.
Then go for:
return !!(this.value && this.value.address);
dwfliplet
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product areas affected
Fliiplet Form Builder
What does this PR do?
Ensures the Map field is displayed in the form settings or on the screen if it is marked as required and user is able to change and save settings like "Field name", "Field label", "Description" etc for any form field.
JIRA ticket
DEV-227
DEV-228