Skip to content

Commit

Permalink
Fix/DEV-217 (#688)
Browse files Browse the repository at this point in the history
* PS-339 [FIX] Ensure Form buttons line up (#681)

* ID-4527 [FIX] Adjust custom button to be in line with form fields (#680)

* Adjust custom button to be in line with form fields

* ID-4527 [FIX] Adjust custom button to be in line with form fields

* PS-53 [FIX] Ensure Rich text field is rendered in Drag and drop accordion of Add fields overlay after switching between settings tabs (#682)

* Revert "PS-53 [FIX] Ensure Rich text field is rendered in Drag and drop accor…" (#687)

This reverts commit 51a8ad5.

* merge with master

* DEV-217 [FIX] Ensure that the Address field and Map field names do not cause conflicts with data source columns.

---------

Co-authored-by: ysolodka <[email protected]>
  • Loading branch information
armine-fliplet and ysolodka authored Oct 29, 2024
1 parent b5d4898 commit 1acbcc0
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions css/form.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
margin: 0;
}

[_type="flCustomButton"] {
justify-content: flex-end;
}

[data-form-field] .col-xs-12 {
padding: 0;
}
Expand Down Expand Up @@ -260,6 +264,7 @@ form.placeholder button {
.btn-link,
a {
text-decoration: underline;
padding: 0;
}

/* FORM STYLES */
Expand Down
2 changes: 1 addition & 1 deletion js/components/customButton.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Fliplet.FormBuilder.field('customButton', {
name: 'Custom button',
name: 'Button',
category: 'Buttons',
props: {
description: {
Expand Down
2 changes: 1 addition & 1 deletion js/libs/builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ Fliplet().then(function() {

case 'flMap':
fieldNames.push('Lat/Long');
fieldNames.push('Address');
fieldNames.push('Map Address');

break;

Expand Down
2 changes: 1 addition & 1 deletion js/libs/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ Fliplet.FormBuilder = (function() {

component.props._flexibleWidthComponents = {
type: Array,
default: ['flInput', 'flCheckbox', 'flRadio', 'flEmail', 'flNumber', 'flTelephone', 'flUrl', 'flTextarea', 'flWysiwyg', 'flSelect', 'flDate', 'flTime', 'flDateRange', 'flTimeRange', 'flTimer', 'flStarRating', 'flSignature', 'flImage', 'flFile', 'flSlider', 'flMatrix', 'flTypeahead', 'flGeolocation', 'flPassword', 'flCodeScanner', 'flCustomButton', 'flMap']
default: ['flInput', 'flCheckbox', 'flRadio', 'flEmail', 'flNumber', 'flTelephone', 'flUrl', 'flTextarea', 'flWysiwyg', 'flSelect', 'flDate', 'flTime', 'flDateRange', 'flTimeRange', 'flTimer', 'flStarRating', 'flSignature', 'flImage', 'flFile', 'flSlider', 'flMatrix', 'flTypeahead', 'flGeolocation', 'flPassword', 'flCodeScanner', 'flCustomButton', 'flMap', 'flAddress']
};

component.props._idx = {
Expand Down
4 changes: 2 additions & 2 deletions js/libs/form.js
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ Fliplet().then(function() {
break;
case 'flMap':
fieldData = {
address: entry.data['Address'],
address: entry.data['Map Address'],
latLong: entry.data['Lat/Long']
};
break;
Expand Down Expand Up @@ -1197,7 +1197,7 @@ Fliplet().then(function() {
});
}
} else if (type === 'flMap') {
appendField('Address', value.address);
appendField('Map Address', value.address);
appendField('Lat/Long', value.latLong);
} else if (type === 'flGeolocation') {
appendField(field.name, value ? value[0] : null);
Expand Down

0 comments on commit 1acbcc0

Please sign in to comment.