chore: Use local api for self hosted snippets #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
Docker builds report
|
Uffizzi Ephemeral Environment
|
matthewelwell
previously approved these changes
Nov 6, 2024
matthewelwell
dismissed
their stale review
Testing via preview link seems to show an issue.
|
I'm not sure if this is a symptom of using the preview URL, but it's showing the API URL being overridden here which I Don't think is correct? 
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # frontend/common/constants.ts
|
This should be resolved now the api url for the sdk docs will adhere to the following
|
|
Sorry, I think it also doesn't work very well in the unified image? 
|
matthewelwell
requested changes
Nov 27, 2024
Comment on lines
+445
to
+447
| Utils.isSaas() || Project.api.startsWith('https://api.flagsmith.com') | ||
| ? Project.flagsmithClientEdgeAPI | ||
| : Project.api, |
There was a problem hiding this comment.
I don't really know what the solution is here, but we need to account for when Project.api is just /api/v1 as per the above screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Uses admin api for SDK snippets instead of flagsmith on flagsmith url. Closes #4130
How did you test this code?
Viewed code snippets in all languages