-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Family member list #158
Merged
Merged
Family member list #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edit in family-member-create
… input when no family chosen
HowardYaw
reviewed
Oct 2, 2021
src/main/webapp/app/shared/components/advancedSearchModal/advancedSearchModal.tsx
Outdated
Show resolved
Hide resolved
…nd and noUserFound
LUXIANZE
previously approved these changes
Oct 9, 2021
HowardYaw
reviewed
Oct 9, 2021
src/main/webapp/app/entities/club-family/family-member-create.tsx
Outdated
Show resolved
Hide resolved
HowardYaw
approved these changes
Oct 10, 2021
CarlosSia
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #134 and #135
For this PR, there is some limitation on the search feature. Where the name search in the Figure 1 is not working, and name search in Advance Search is using Jhipster .equals search which is lack of flexibility and not very useful. New issue #157 is created on resolve this issue and this will be fixed using Lu's implementation.
Screenshot
Figure 1: View Family Member List
Figure 2: Advanced Search
Figure 3: Add New Member
Figure 4: Update existing Family Member
5. Figure 5: Update existing Family Member (Family is set as None)